Improve performance and Material 3 expressive UI - #1
Open
Rabkaps wants to merge 3 commits into
Open
Conversation
- Fixed UI stuttering at launch by moving heavy settings and subscription parsing loads off the main UI thread during initial composition. - Refactored `WaveVisualizer` animation loops using proper `Animatable` float arrays inside coroutines rather than continuous `while(true)` loops calculating sines and cosines on the main thread. - Increased the prominence of the Material 3 Expressive shapes by making corner radii closer to spec defaults. - Updated the theme colors to not enforce pure black on surface containers when using dark mode to allow natural expressive tints to show through. - Used `AnimatedContent` for search bar toggle transitions to reduce layout jumping and improve the UX. - Resolved compile SDK dependency mismatch errors in build.gradle.kts. Co-authored-by: Rabkaps <102897583+Rabkaps@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Fixed UI stuttering at launch by moving heavy settings and subscription parsing loads off the main UI thread during initial composition. - Refactored `WaveVisualizer` animation loops using proper `Animatable` float arrays inside coroutines rather than continuous `while(true)` loops calculating sines and cosines on the main thread. - Increased the prominence of the Material 3 Expressive shapes by making corner radii closer to spec defaults. - Updated the theme colors to not enforce pure black on surface containers when using dark mode to allow natural expressive tints to show through. - Used `AnimatedContent` for search bar toggle transitions to reduce layout jumping and improve the UX. - Resolved compile SDK dependency mismatch errors in build.gradle.kts. Co-authored-by: Rabkaps <102897583+Rabkaps@users.noreply.github.com>
- Fixed UI stuttering at launch by moving heavy settings and subscription parsing loads off the main UI thread during initial composition. - Refactored `WaveVisualizer` animation loops using proper `Animatable` float arrays inside coroutines rather than continuous `while(true)` loops calculating sines and cosines on the main thread. - Increased the prominence of the Material 3 Expressive shapes by making corner radii closer to spec defaults. - Updated the theme colors to not enforce pure black on surface containers when using dark mode to allow natural expressive tints to show through. - Used `AnimatedContent` for search bar toggle transitions to reduce layout jumping and improve the UX. - Resolved compile SDK dependency mismatch errors in build.gradle.kts. - Added `.animateItem()` to List items for smoother UI. Co-authored-by: Rabkaps <102897583+Rabkaps@users.noreply.github.com>
Rabkaps
force-pushed
the
main
branch
11 times, most recently
from
June 28, 2026 20:20
b79c72c to
91f02df
Compare
Rabkaps
added a commit
that referenced
this pull request
Aug 2, 2026
…race condition BUG #1 (CRITICAL): MainActivity shortcut 'Connect Fastest' sequential pings → Now uses concurrent async pings (~2s instead of 100s), staying within the Android 12+ ForegroundService exemption window. BUG #2 (CRITICAL): CdnIpScanner.getCleanIp() bare runBlocking → Now uses runBlocking(Dispatchers.IO) to prevent main-thread ANR. BUG #3 (CRITICAL): CensorshipDiagnostics TLS test ignored SNI parameter → Now wraps plain socket with sslFactory.createSocket(socket, sni, port) so the SNI extension is properly set in the TLS ClientHello. BUG #6/7 (HIGH): IpCountryResolver blocking IO + cache race condition → Added @synchronized to saveCache() to prevent file corruption. → Added NetworkOnMainThreadException catch for DNS resolution fallback. BUG #8 (HIGH): VpnQuickSettingsTileService unlockAndRun delays FGS start → Removed unlockAndRun wrapper. VPN service starts immediately regardless of lock state, preventing ForegroundServiceStartNotAllowedException.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the user's issue concerning app lag/stutter at launch and visual updates.
I have:
LaunchedEffectblocks handling network subscription updates and setting resolutions to run explicitly viaDispatchers.IOso that they don't block the UI thread during composition.WaveVisualizercalculating arrays on every frame into properAnimatabletransitions in loops with a long duration, reducing composition passes.AnimatedVisibilityandAnimatedContentstructures for transitions.PR created automatically by Jules for task 15161341920059722547 started by @Rabkaps