Skip to content

fix(connect): don't block PSBT approval for already-signed own inputs #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheArtofSatoshi merged 1 commit into from
Jul 27, 2026
Merged

fix(connect): don't block PSBT approval for already-signed own inputs #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/app/src/connect/psbtFlow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,10 +158,19 @@ export async function enrichPsbt(psbt: Psbt): Promise<EnrichedPsbt> {
}

const allFinalized = analysis.inputs.every((i) => i.finalized);
// How many of the wallet's own inputs still need a NEW signature this
// approval — used for the "N of your inputs will be signed" display text.
const signableCount = analysis.inputs.filter(
(i, idx) => i.mine && !i.finalized && !i.hasPartialSig && !inputs[idx].scriptMismatch
).length;
if (signableCount === 0 && !allFinalized) {
// Whether ANY input belongs to the wallet at all, regardless of whether
// it's already signed — a PSBT whose own inputs are already validly
// signed (just not yet finalized, e.g. mid multi-party hand-off) still has
// a legitimate stake here and shouldn't be refused as "not yours".
const mineCount = analysis.inputs.filter(
(i, idx) => i.mine && !inputs[idx].scriptMismatch
).length;
if (mineCount === 0 && !allFinalized) {
blockers.push("None of this transaction's inputs belong to your wallet.");
}

Expand Down
Loading