test: add ProjectAccess and ProjectPolicyGuard coverage - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define ProjectAcces object and ProjectPolicyGuard
Why
Both objects are used for authorization access, ProjectAccess represents an access attempt with the id of project, id of member that want to access and project configuration to know how to act according to project policies, this encapsulate the authorization logic to allow or not the access. The ProjectPolicyGuard is an object that intercepts the request before it reach the application layer, this gets a ProjectAccess object from repository, the repository may thorw erros in case that the member project doesnt contain the member, project inactive or deleted
What was made