Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a small greeting script and modifies an existing greeter script to print an additional line of output.
Changes:
- Added
camilo_script.shthat echoes a simple greeting. - Updated
10-greeter.shto print an extra informational line after reading the user’s name.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| camilo_script.sh | New bash script that prints a greeting. |
| 10-greeter.sh | Adds an extra echo line to the interactive greeter flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| echo "Please enter your name" | ||
| read name | ||
|
|
||
| echo "This line was added by Camilo on the new-feature branch" |
There was a problem hiding this comment.
The added echo prints branch/author metadata every run, which changes the script’s user-facing output without affecting greeting logic. Please remove it, or gate it behind an explicit verbose/debug flag if it’s intended for diagnostics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.