Remove orphaned old-target app builds (1.5.0, 1.6.0) - #30
Merged
Conversation
These older Ledger-firmware-target app.apdu/app.elf builds under apps/{flex,nanosp}/
are superseded by 1.6.1 and referenced by nothing: embed-artifacts bundles 1.6.1,
install-app reads the top-level current-version alias, and the installer tests read
the top-level + 1.6.1. The top-level apps/*/app.* alias (test-enforced == 1.6.1) stays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the superseded on-device app builds for the old
1.5.0and1.6.0firmware targets (flex + nanosp
app.apdu/app.elf). The current installtarget is
1.6.1 (clear-sign-v1), bundled separately; nothing in the source,scripts, or manifest references the old builds. Drops 8 binaries / ~956 lines of
dead weight from the repo.