Skip to content

Zy0n/update phase - #87

Merged
zy0n merged 17 commits into
mainfrom
zy0n/update-phase
Dec 10, 2025
Merged

Zy0n/update phase#87
zy0n merged 17 commits into
mainfrom
zy0n/update-phase

Conversation

@zy0n

@zy0n zy0n commented May 16, 2025

Copy link
Copy Markdown
Contributor

This pull request introduces enhanced validation for transactions by adding support for relay and proxy contract checks, decoding transaction data, and validating relay-specific calls. It also updates the createValidTransaction function and its usages to include the chain context. Below is a summary of the most important changes:

Enhancements to transaction validation:

  • Added support for validating transactions targeting relay and proxy contracts by introducing checkIsProxyAddress and checkIsRelayAdaptAddress helper functions. These ensure the to address is a known contract.
  • Implemented relay-specific validation logic by decoding transaction data using the ABI_RELAY_ADAPT ABI, checking if the call is a relay call, and validating the relay call data.

Updates to createValidTransaction:

  • Modified the createValidTransaction function to accept a chain parameter, enabling chain-specific validation for proxy and relay addresses.

Integration with existing functionality:

  • Updated transactMethod in src/server/waku-broadcaster/methods/transact-method.ts to pass the chain parameter when calling createValidTransaction. [1] [2]

ABI and imports:

  • Added ABI_RELAY_ADAPT to the list of imported ABIs and exported it for use in transaction validation.
  • Extended imports from ethers to include Interface, InterfaceAbi, and TransactionDescription for decoding and validating transaction data.

Test updates:

  • Updated the test for createValidTransaction in transaction-validator.test.ts to include the new chain parameter in the function call.

@zy0n
zy0n marked this pull request as draft May 16, 2025 21:02
@zy0n
zy0n requested a review from mesquka May 16, 2025 21:02
@socket-security

socket-security Bot commented Jun 5, 2025

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​railgun-community/​shared-models@​7.5.0 ⏵ 8.0.07610074 -187 +2100
Updated@​railgun-community/​wallet@​10.3.3 ⏵ 10.8.177 +310084 +294 +4100

View full report

@socket-security

socket-security Bot commented Jul 28, 2025

Copy link
Copy Markdown

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@zy0n
zy0n requested a review from bhflm July 28, 2025 23:26
@zy0n
zy0n marked this pull request as ready for review December 10, 2025 14:38
@zy0n
zy0n requested a review from mattgle December 10, 2025 14:39
mattgle
mattgle previously approved these changes Dec 10, 2025
@zy0n
zy0n merged commit ec49691 into main Dec 10, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants