Fix: correct WBNB symbol label on BSC - #90
Open
munikes wants to merge 1 commit into
Open
Conversation
TokenAddressBSC.WBNB (0xbb4cdb9cbd36b01bd1cbaebf2de08d9173bc095c) was labeled with symbol 'WETH' in BLUECHIP_BSC. The token itself is a legitimate, liquid asset and prices resolve fine regardless (price lookups are by address, not symbol), but the label is misleading in logs and any UI that surfaces the symbol.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TokenAddressBSC.WBNB(0xbb4cdb9cbd36b01bd1cbaebf2de08d9173bc095c) is labeled withsymbol: 'WETH'inBLUECHIP_BSC(config-token-sets.ts).The token itself is legitimate and liquid — WBNB is BSC's native wrapped token, actively traded with a real market price — so this doesn't break price lookups (CoinGecko queries by contract address, not symbol). But the mislabel is misleading in broadcaster logs and anywhere the symbol is surfaced.
Fix
Corrected the symbol from
'WETH'to'WBNB'.Verification
Confirmed on PolygonScan/BscScan that
0xbb4cdb9cbd36b01bd1cbaebf2de08d9173bc095cis the canonical Wrapped BNB contract on BSC.