Skip to content

Fix: batch CoinGecko token price requests #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
munikes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: batch CoinGecko token price requests #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 14 additions & 22 deletions src/server/api/coingecko/coingecko-price.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,28 +41,20 @@ const coingeckoPriceLookup = async (
): Promise<TokenAddressPrice[]> => {
const currency = 'usd';

const paramArr = tokenAddresses.map((address) => {
return {
contract_addresses: address,
vs_currencies: currency,
include_last_updated_at: true,
};
});
let coingeckoPriceMap: CoingeckoPriceMap = {};
for (const params of paramArr) {
try {
// eslint-disable-next-line no-await-in-loop
const geckoPriceMap: CoingeckoPriceMap = await getCoingeckoData(
CoingeckoApiEndpoint.PriceLookup,
coingeckoNetworkId,
params,
);
coingeckoPriceMap = { ...coingeckoPriceMap, ...geckoPriceMap };
// eslint-disable-next-line no-await-in-loop
await delay(250);
} catch (error) {
console.error(error);
}
try {
const geckoPriceMap: CoingeckoPriceMap = await getCoingeckoData(
CoingeckoApiEndpoint.PriceLookup,
coingeckoNetworkId,
{
contract_addresses: tokenAddresses.join(','),
vs_currencies: currency,
include_last_updated_at: true,
},
);
coingeckoPriceMap = { ...coingeckoPriceMap, ...geckoPriceMap };
} catch (error) {
console.error(error);
}

const tokenPrices = tokenPriceArrayFromCoingeckoPriceMap(
Expand All @@ -77,7 +69,7 @@ export const coingeckoUpdatePricesByAddresses = async (
tokenAddresses: string[],
updater: TokenPriceUpdater,
): Promise<void> => {
const batchSize = 50;
const batchSize = 30; // CoinGecko Demo API tier limit is 30 addresses per request
for (let i = 0; i < tokenAddresses.length; i += batchSize) {
const batch = tokenAddresses.slice(i, i + batchSize);
// eslint-disable-next-line no-await-in-loop
Expand Down