docs: warn about priceTTLInMS vs refreshDelayInMS interaction - #95
Open
munikes wants to merge 1 commit into
Open
docs: warn about priceTTLInMS vs refreshDelayInMS interaction#95munikes wants to merge 1 commit into
munikes wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If refreshDelayInMS (e.g. raised to save CoinGecko free-tier quota) ends up higher than priceTTLInMS, every refresh cycle has a guaranteed window where cached prices are considered expired before the next fetch happens — the broadcaster silently stops publishing fees for every token (NO TOKEN PRICE warnings) even though the underlying CoinGecko call is succeeding. Added an explicit comment next to defaultTokenPriceTTL warning about this.