Don't crash on an impossible date in a resource filename - #216
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
`date_from_filename` matches `\d{4}-\d{2}-\d{2}-` and passes the parts
straight to `Date.new`, so a file named `2024-99-99-post.md` raises
`Date::Error: invalid date`. That propagates through `publication_date`
and `published?`, so a single typo'd filename takes down the whole
collection load.
Rescue `Date::Error` and treat the prefix as not-a-date, the same as a
filename with no date prefix at all.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GtYgwYNfJ3wHrw9xrooVoB
Author
|
CI is on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
Publishable#date_from_filenamematches/^\d{4}-\d{2}-\d{2}-/and hands the captured groups toDate.new:The regex is structural, so
2024-99-99-post.mdmatches andDate.new(2024, 99, 99)raisesDate::Error: invalid date. It propagates throughpublication_date→published?→Collection#all, so one typo'd filename breaks the whole collection load.The fix
Rescue
Date::Errorand treat the prefix as not-a-date — the same outcome as a filename with no date prefix.Tests
resource_publishable_test.rb— a2024-99-99-…mdfile:publication_dateisnilandpublished?doesn't raise. Fails onmain(Date::Error).bundle exec rakeis green (402 runs, 0 failures;standardrbclean).🤖 Generated with Claude Code