Implement paper#33
Conversation
| import numpy as np | ||
|
|
||
| import sys | ||
| import matplotlib.pyplot as plt |
There was a problem hiding this comment.
Are these imports necessary? I don't see them being used. =/
There was a problem hiding this comment.
Thanks. I don't know what it went there. I am removing it now.
axiezai
left a comment
axiezai
left a comment
There was a problem hiding this comment.
I am sort of confused by the naming, I don't see network_transfer_P anywhere in this file, and I see that you went back and forth with it in a previous commit 3d0a233.
We should also avoid function names like network_transfer_P, it's not intuitive. Same goes for network_transfer_local_alpha, The names should be straightforward, and the detailed description should go into the block comment describing the function.
| @@ -1,47 +1,8 @@ | |||
| """ running the ntf over a range of frequencies.""" | |||
| from ..forward import network_transfer as nt | |||
| from ..forward import network_transfer_P as nt | |||
There was a problem hiding this comment.
Does forward.network_transfer_P exist?
There was a problem hiding this comment.
So I had it at some point just because I was playing with some stuff but removed it later on. I don't have network_transfer_P in the final version that I sent you (right?). Do you want me to remove that commit from the history?
So network_transfer_local_alpha is the naming convention you had. I think we should discuss on how we want to keep the names. I think we can remove network_transfer_function and replace it with network_transfer_local_alpha. If you like this idea, I will go ahead with it. Let me know.
There was a problem hiding this comment.
From the looks of the code from ..forward import network_transfer_P is in the code of the pull request, if that function doesn't exist in forward, what are we importing? Does nt run in your local copy? The import should fail if forward doesn't have the function.
Let's discuss naming in the zoom meeting.
2 participants
Hey Bobby!
Here is the updated code. I did not remove any functions but only modified the .._local_alpha. I had earlier deleted the other functions. Sorry for the delay. I am a newbie in all of this. Will appreciate any feedback and let me know if something is wrong.
Parul