Skip to content

Validate release promotion CI repairs for #3095 - #3096

Closed
JBailes wants to merge 796 commits into
mainfrom
fix/release-promotion-ci
Closed

JBailes wants to merge 796 commits into
mainfrom
fix/release-promotion-ci

Conversation

@JBailes

@JBailes JBailes commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Validate the exact promotion repair commit before advancing protected testing for #3095. This PR is not a merge request: the main source-branch guard must remain red because only testing may merge to main. Once the six required testing checks pass, the identical commit will update #3095.

The repair refreshes reviewed source/surface snapshots and locks synthesis promotion to the two E2E-validated immutable b10219 images, without rebuilding or publishing. The owner approved only the exact historical closed PR app identities #3030–3037, #3042–3046 and #3051 and four exact Claude commit identities from #3032–3035. Code pins repository, app, head, merge/state or exact SHA/author/committer values. History stays intact; unknown identities, API failures, title/body attribution and message trailers remain blocked. Automatic reviews remain enabled.

The four editable Generated-by footers on historical PRs #3032–3035 were removed through Aimee; original bodies were retained in the local audit. Immutable app badges and Git commit history remain intact. This corrects the metadata while retaining strict title/body checks.

Validation: attribution package and API failure tests; 9 synthesis release/promotion tests; 11 model-input tests; 7 application-lock and 8 surface-baseline tests; both current lock checks, cleanup accounting and release-policy checks passed locally. GitHub has passed the application source/surface gates and both synthesis promotion-source validations on the first repair commit. The full rerun is required on the final head.

…s-git-usage

# Conflicts:
#	.github/workflows/bench-smoke.yml
#	.github/workflows/benchmark.yml
#	.github/workflows/ci.yml
#	.github/workflows/fuzz-nightly.yml
…n-verdicts

Bind historical attribution verdicts to their assessed range
aimee compiled the ring itself: src/Makefile listed the ring's C source files,
compiled them with the ring's private c/src on the include path, the test rules
linked individual ring objects, the module bundle compiled ring client sources
by name, and the lock and go.mod both had to name one exact commit. aimee was
bound to the ring's file layout, not to what the ring promises.

Now aimee names the release range it accepts in dependencies/ouroboros-ring.json
(compatible 0.1, semver) and links an installed ring through the ring's own
package (pkg-config / CMake ouroboros-ring). scripts/provide_ouroboros_ring.py
provides that installation: OURO_RING_PREFIX uses any installed ring whose
declared version is in range, OURO_RING_SOURCE builds a ring checkout, and by
default release v0.1.0 is fetched, checked against its content digest and built
with the ring's own CMake, with the caller's compiler and extra flags (so the
sanitizer lane links an instrumented ring). A dry run provides nothing. The Go
module requires the tagged release go/v0.1.0, and make go-unit-tests checks it
is in range.

- src/Makefile and CMakeLists.txt consume the package; test rules link the
  installed archive; the bundle builder links ouroboros-ring-client.
- check_bus_blast_radius.sh fails on any reach into ring sources or objects,
  and checks the installed client package defines no ouro_host_ entry point.
- Exports build against the release tag; publish-testing and the planner
  watch the new file; cmake is in every image and job that runs make.
- fetch_ouroboros_ring.py and ouroboros-ring.lock.json are gone; an old
  fetched tree in build/deps is removed on first use.
…usage

fix: make get-help topics and bare aimee git usage real
…nd-editor

Unify internal model communication on IR and repair browser thinclient sessions
The merge from testing made the Makefile pass aimee's -fno-ipa-bit-cp into the
ring build, which put a fact about the ring's code in aimee. Ring v0.1.1 turns
the pass off in its own build for GCC, so aimee goes back to passing only its
compiler and extra flags, and names v0.1.1 (C default release and Go module).
Merging origin/testing wrote the new agent_credentials.c and
test_delegate_credentials.c into the worktree but did not stage them, so the
merge commit kept the old versions and reverted testing's change; the test
then failed to compile against testing's headers (unit-tests shards). Take
testing's versions unchanged.
Reference the ouroboros ring by contract, not by commit
… config at start

Legacy from the ring's move:
- docs/dev/EVENT_BUS_DECISIONS.md duplicated the ring's spec/decisions.md,
  EVENT_BUS_FEATURE_TREE.md was the finished build plan, and the arena guide
  moved to the ring rewritten for the current API. aimee's own decision (which
  binaries link the ring, and the audit row's durability) moves into
  docs/EVENT_BUS.md; links point at the ring.
- check_bus_d1_gate.sh guarded a decision accepted months ago.
- bus_bench.c, check_bus_perf_gate.sh and bus_baseline.json: the dispatch
  benchmark is the ring's and now runs in its CI. The audit row's enqueue
  budget is aimee's and stays as check_audit_bus_budget.sh with
  audit_bus_budget.json; the gate's other sections repeated tests unit-tests
  already runs.
- test_bus_flow.c keeps only what is aimee's, ring loss facts reaching the
  WORM ledger; the flow-control semantics it tested are now the ring's own
  test_flow.c.
- Citations of bus_host_*, src/core/event_bus and libaimee-core-event-bus.

aimee-core-c: the repository is gone and nothing consumed it. The lock no
longer pins it (and the lock check refuses a core pin), the exporter no longer
produces it, generated C module CI no longer checks it out, and generated C
module builds no longer find_package(aimee-core), which they never linked. The
core stays bundled and core-c-package CI still proves it installs.

Ring 0.1.2: obs_bus and test_module_runtime attach in-process clients with
ouro_host_attach_local and obs_bus persists capture with
ouro_capture_flush_fd, instead of carrying their own copies. compatible
accepts a floor within a line (0.1.2) so the pin says which release the
API arrived in.

Startup race: the supervisor starts every module at once, and memory and
egress read config before serving, exiting on capability absent when config
was a moment behind. config.SnapshotWhenServed retries that one answer for up
to 30 s; any other failure still stops the module.
test_obs_bus_module_concurrency compiles obs_bus.c in and reused its private
serve thread to check that an owned private pair refuses a client claiming an
external identity. ouro_host_attach_local cannot send a claimed identity, so
the test keeps a three-line serve thread of its own.
Remove ring-move legacy, drop aimee-core-c, consume ring 0.1.2, fix the memory/config startup race
The postgres module registers its stages before its database is reachable,
by design, and answers SQL in that window with "the SQL stage has no
database". The store's startup wait retried only an unreachable module, so
when postgres was attached but not yet connected the aimee module exited and
the supervisor restarted it (seen twice in the 2026-10-28 :testing QUICKSTART
on .252, the same race memory had with config).

The refusal now carries SQLSTATE 08001, as the session stage already does for
an unavailable pool, and the store client reports any class-08 refusal as
ErrStoreUnavailable with the store's reason kept. The store's bounded 30 s
wait therefore covers it; refusals on the merits are unchanged.
The parallel runner already records each failing test with its last
40 lines. On GitHub Actions, emit those records as ::error annotations
too, so the failing test and its output show on the check run itself
without opening the raw job log.
…database

The store waits for postgres to reach its database, not only to attach
The ring is Linux-only (SOCK_SEQPACKET endpoints opened with SOCK_CLOEXEC
and accept4), but since the ring moved to a contract reference the
Makefile built it on every platform, before any target. The macOS LSP
probe never links the ring, yet its build stopped in the ring's own
compiler, which has failed the macOS lsp-real-providers job on testing
since that change.

Off Linux, provide_ouroboros_ring.py --headers now supplies just the
ring's public headers, from the same release and content digest (or the
installed/source ring, range-checked as before), without building it.
The probe still needs them: the module-call API names ring result types.
A product that links the ring stops with a plain message instead.
Unit-test shards have been failing intermittently (pg 2/3 twice, pg
3/3 and sqlite 3/4 once each) and none of them could be diagnosed
without the raw job log. The per-test annotation only covers a test
that fails inside the runner loop; testing's pg 3/3 failure happened
before any test recorded itself.

These steps now keep their whole output, and if they fail a following
step posts its last 60 lines as an error annotation. The LSP probe
build gets the same treatment, so the macOS leg is readable too.
The blast-radius check attributes every OURO_RING_LIB reference to the
target that owns it; a rule whose target was $(OURO_RING_LIB) read as a
new product linking the ring. Name the stop target by its own variable.
…output

Show the tail of a failed unit-test or LSP-probe step on the check run
…4aab76a68859be7

Prepare 1.1.0: ship aims-db memory baked into the image
…ockers

Fix release promotion blockers in account activation, Vault startup, and upgrades
@JBailes
JBailes requested a deployment to main-merge-approval November 16, 2026 14:49 — with GitHub Actions Waiting
@JBailes JBailes closed this Nov 16, 2026
@JBailes
JBailes deleted the fix/release-promotion-ci branch November 16, 2026 14:57
@JBailes
JBailes deployed to main-merge-approval November 16, 2026 15:06 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
main-merge-approval — 81d7a5b9 Deployed Nov 16, 2026 by JBailes via approval #77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant