Repository navigation
Restore the required Windows CMake check context - #3097
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main branch still requires windows-cmake, but that job was retired when Windows was reduced to the shipping thin client. The successful current job reports windows-build, leaving the promotion at Expected / Waiting for status.
Restore windows-cmake as a dependency gate over the actual Windows CMake build and Winsock smoke tests. Preserve windows-build, avoid a second compilation, and fail on failure, cancellation or an unexplained skip. A skip qualifies only when change-scope successfully proves a documentation-only change. Branch protection and automatic reviews remain enabled.
Validation: four gate tests execute the actual workflow shell for success, failure, cancellation, unknown results and proven/unproven documentation skips; CI change-scope tests, application source lock and surface baseline checks pass. Fixes the missing required status on promotion #3095.