Skip to content

Restore the required Windows CMake check context - #3097

Merged
JBailes merged 2 commits into
testingfrom
fix/windows-cmake-required-check
Nov 16, 2026
Merged

JBailes merged 2 commits into
testingfrom
fix/windows-cmake-required-check

Conversation

@JBailes

@JBailes JBailes commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

The main branch still requires windows-cmake, but that job was retired when Windows was reduced to the shipping thin client. The successful current job reports windows-build, leaving the promotion at Expected / Waiting for status.

Restore windows-cmake as a dependency gate over the actual Windows CMake build and Winsock smoke tests. Preserve windows-build, avoid a second compilation, and fail on failure, cancellation or an unexplained skip. A skip qualifies only when change-scope successfully proves a documentation-only change. Branch protection and automatic reviews remain enabled.

Validation: four gate tests execute the actual workflow shell for success, failure, cancellation, unknown results and proven/unproven documentation skips; CI change-scope tests, application source lock and surface baseline checks pass. Fixes the missing required status on promotion #3095.

@JBailes
JBailes merged commit 56d9b0f into testing Nov 16, 2026
56 checks passed
@JBailes
JBailes deleted the fix/windows-cmake-required-check branch November 16, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant