Repository navigation
fix(updates): clear superseded install failures; don't let one source… - #506
Merged
Merged
Conversation
… block installs The WTR Max's Updates page still said "Installing updates failed (2026-11-01T15:36:28Z)" a day later. That install, started from the page, failed because apt.bcachefs.org refused connections; unattended upgrades had since installed kernel 7.2.15-84 and OpenZFS without an error, but the page only reads the last run started from it. - A failed install older than /var/lib/apt/periodic/upgrade-stamp, which apt.systemd.daily touches only when unattended-upgrade exits 0, is reported as superseded: the page shows it as history, with when updates last installed. Failed checks are not cleared this way: the unattended refresh runs in apt's default mode, which exits 0 even with an unreachable archive. - An install no longer stops when a package source can't be refreshed. One third-party archive being down kept SmoothNAS's own updates from installing. The refresh still runs with Error-Mode=any, its result is logged on its own line, and the install runs regardless. An install that succeeded with a failed refresh says so, and lists the sources. Tests: - Go: the WTR Max log superseded by a newer upgrade-stamp; not superseded by an older or same-second stamp, a missing stamp, a failed check, a successful or unfinished install. The generated install script is run under /bin/sh with stub apt-get/dpkg: a failed refresh still installs and is recorded, a failed install keeps its exit code, a clean run reports nothing. Mutation-checked. - Browser: the superseded WTR Max failure shows no error, the same failure without a later success still does (negative control), and a successful install with a failed refresh shows its warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… block installs
The WTR Max's Updates page still said "Installing updates failed (2026-11-01T15:36:28Z)" a day later. That install, started from the page, failed because apt.bcachefs.org refused connections; unattended upgrades had since installed kernel 7.2.15-84 and OpenZFS without an error, but the page only reads the last run started from it.
Tests: