Skip to content

Point release - #507

Merged
JBailes merged 16 commits into
mainfrom
testing
Nov 2, 2026
Merged

JBailes merged 16 commits into
mainfrom
testing

Conversation

@JBailes

@JBailes JBailes commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Bootstrap private credentials before starting PBS, retain tier-backed data, and expose its direct HTTPS interface. Pin the runtime secret-logging fixes and smoothfs durability fixes in both backend and appliance validation paths. Record live validation and the dependency release gate before shipping.
Pin the tested smoothfs fixes for repeated movement, mkdir error cleanup and complete non-root directory enumeration. Record the live GC data-loss finding, corrected recovery/restore results and verified fixture cleanup.
Add experimental PBS plugin with validated storage durability requirements
Connect reusable Google accounts through the device flow and run Drive
backup/restore jobs with rclone, exclusions and optional encryption.
Require acknowledgement of a separately stored recovery kit before saving
encrypted jobs, and redact credentials from run errors.

Add persistent daily schedule claims, catch-up, overlap prevention and DST
handling for every backup method. Preserve existing backup data through
migrations and ship rclone through the SmoothNAS package dependency list.

Validation: backend and targeted race tests, stock-rclone local encrypted
round trips and independent recovery, database upgrade coverage, mocked
Google OAuth flow, frontend TypeScript check and production build.

Real Google account and NAS installation validation remain outstanding.
Add Google Drive backups and weekday scheduling
The installer pins NIC names with 00-net<N>.link files that match on
MACAddress=, which udev compares against a device's current address.
Since #487, tierd gives a bond its first member's MAC, so the bond also
matches that member's .link file. udev then races the bond and the NIC
for the name: on an Aoostar WTR Max with kernel 7.2.14 the bond wins,
bond0 becomes net0, the real NIC is left as eth1, networkd fails with
"Cannot enslave bond to itself", and the NAS boots with no address.

- Match NIC naming .link files on PermanentMACAddress=, which bonds,
  VLANs and other software links don't have. tierd rewrites existing
  MACAddress=-only files at startup and reloads udev; the installer
  patch writes the new selector on fresh installs.
- Add smoothnas-network-fallback.service: if no networkd-managed link is
  routable 90s after a physical NIC has carrier, release the NICs from
  their bond and DHCP each one, via /run config that lasts until the
  next boot. The clock starts at carrier so a slow switch after a power
  cut doesn't make a correctly configured box give up its address.

Tests:
- Go: migration, and an invariant that no .link selector matches a MAC
  tierd pins on a bond (fails with the WTR Max symptom without the fix).
- packaging/tests/network-fallback-test.sh: fake sysfs and stubbed
  networkctl/ip, including the WTR Max layout, no carrier, late switch,
  and unmanaged-only routes.
- scripts/ci/test-link-bond-rename.sh (new CI job): a real bond under
  real udev. A MACAddress= link must rename it (negative control), a
  PermanentMACAddress= link must not, and must still match a real NIC.
- CI checks that the patched installer writes PermanentMACAddress=.
…r headers

On the Aoostar WTR Max's Nov 1 upgrade, apt configured
linux-image-7.2.14-83-smoothkernel before its headers. The image's DKMS
hook skipped the kernel ("headers ... do not seem to be installed"), and
SmoothKernel's bindeb-pkg headers package has no postinst to rerun
/etc/kernel/header_postinst.d as Debian's does. ZFS was never built for
7.2.14-83, so after the reboot the pool didn't import, the smoothfs pool
on it couldn't mount, and enabling SMB failed with "A dependency job for
smbd.service failed" (NFS the same).

- /usr/lib/smoothnas/dkms-autoinstall.sh runs `dkms autoinstall` for
  every installed kernel whose headers are present, keeps going past a
  failed kernel, and names it.
- The smoothnas postinst runs it, so the standard update repairs a box
  already in this state; apt.conf.d/53smoothnas-dkms runs it after every
  dpkg run, so later kernel upgrades get their modules whatever order
  apt configures packages in. Neither can fail a dpkg run.

Tests:
- packaging/tests/dkms-autoinstall-test.sh (stub dkms, fake
  /lib/modules): the WTR Max layout, headers arriving on a later run, a
  failing kernel, and the apt hook and postinst tolerating failure.
- CI package job, real DKMS on Debian 13: unbuild zfs for the installed
  SmoothKernel, assert it's gone, and check an unrelated apt run rebuilds
  it; then the same for smoothfs through the postinst alone.
… block installs

The WTR Max's Updates page still said "Installing updates failed
(2026-11-01T15:36:28Z)" a day later. That install, started from the
page, failed because apt.bcachefs.org refused connections; unattended
upgrades had since installed kernel 7.2.15-84 and OpenZFS without an
error, but the page only reads the last run started from it.

- A failed install older than /var/lib/apt/periodic/upgrade-stamp, which
  apt.systemd.daily touches only when unattended-upgrade exits 0, is
  reported as superseded: the page shows it as history, with when
  updates last installed. Failed checks are not cleared this way: the
  unattended refresh runs in apt's default mode, which exits 0 even
  with an unreachable archive.
- An install no longer stops when a package source can't be refreshed.
  One third-party archive being down kept SmoothNAS's own updates from
  installing. The refresh still runs with Error-Mode=any, its result is
  logged on its own line, and the install runs regardless. An install
  that succeeded with a failed refresh says so, and lists the sources.

Tests:
- Go: the WTR Max log superseded by a newer upgrade-stamp; not
  superseded by an older or same-second stamp, a missing stamp, a failed
  check, a successful or unfinished install. The generated install
  script is run under /bin/sh with stub apt-get/dpkg: a failed refresh
  still installs and is recorded, a failed install keeps its exit code,
  a clean run reports nothing. Mutation-checked.
- Browser: the superseded WTR Max failure shows no error, the same
  failure without a later success still does (negative control), and a
  successful install with a failed refresh shows its warning.
fix(updates): clear superseded install failures; don't let one source…
@JBailes
JBailes merged commit 2a7d3af into main Nov 2, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant