Repository navigation
Restore the intro sword prop attachment pose - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intro’s separately attached sword prop retained its standalone resting lift and hip rotation on top of the mounting bone’s transform. This displaced the sword from its intended position in the corpse.
When a static prop plays its rest clip while attached, reset its first two bones to their bind poses so the mounting frame supplies the placement. Reapply attached actors after animation advances, keeping the prop on the current parent pose. Standalone props regain their rest animation after detachment, and the previous held-weapon projection repair remains intact.
Validation:
Published release: https://github.com/RakuenSoftware/vagrant/releases/tag/v0.1.0-preview.9
CI: https://github.com/RakuenSoftware/vagrant/actions/runs/43720940410