Skip to content

Fix key-scan false positives and retry audited SDK publication - #4

Merged
JBailes merged 1 commit into
mainfrom
fix/key-material-audit
Nov 15, 2026
Merged

JBailes merged 1 commit into
mainfrom
fix/key-material-audit

Conversation

@JBailes

@JBailes JBailes commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

All three native builds compiled and passed the binary-only consumer probe, but publication was blocked by a credential-scan false positive. The unchanged official Godot editor contains PEM format header strings for its cryptographic implementation; a header alone is not private key material.

Require a complete PEM block with encoded payload and matching key-type footer, while retaining GitHub credential detection and all source/symbol/file-inventory exclusions. Add regressions accepting an isolated format marker and rejecting complete encoded key blocks in editor binaries. Expected audit failures now report only fixed public rule labels; rejected file names/content and unexpected parser diagnostics remain withheld. A CLI regression verifies that failed archives produce no approved output and do not echo their contents.

Request attempt 3 for the existing tagged engine revision so merging automatically retries Linux, Windows and universal macOS builds. No source or SDK artifacts were uploaded by the failed run; no release was created.

Validation: eleven tests pass, actionlint passes, complete public-history audit passes, and the corrected credential detector passes against every file in all three cached published SDK archives. Every publicly reported policy label was verified to be a fixed literal. No SDK images were built or repackaged locally.

@JBailes JBailes changed the title Distinguish private key material from cryptographic format markers Fix key-scan false positives and retry audited SDK publication Nov 15, 2026
@JBailes
JBailes merged commit 770083f into main Nov 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant