Repository navigation
Fix key-scan false positives and retry audited SDK publication - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All three native builds compiled and passed the binary-only consumer probe, but publication was blocked by a credential-scan false positive. The unchanged official Godot editor contains PEM format header strings for its cryptographic implementation; a header alone is not private key material.
Require a complete PEM block with encoded payload and matching key-type footer, while retaining GitHub credential detection and all source/symbol/file-inventory exclusions. Add regressions accepting an isolated format marker and rejecting complete encoded key blocks in editor binaries. Expected audit failures now report only fixed public rule labels; rejected file names/content and unexpected parser diagnostics remain withheld. A CLI regression verifies that failed archives produce no approved output and do not echo their contents.
Request attempt 3 for the existing tagged engine revision so merging automatically retries Linux, Windows and universal macOS builds. No source or SDK artifacts were uploaded by the failed run; no release was created.
Validation: eleven tests pass, actionlint passes, complete public-history audit passes, and the corrected credential detector passes against every file in all three cached published SDK archives. Every publicly reported policy label was verified to be a fixed literal. No SDK images were built or repackaged locally.