fix(deps): resolve @isaacs/brace-expansion DoS vulnerability (GHSA-7h2j-956f-4vf2) #COMW-127#30
Merged
Conversation
lukaszjaskowski
requested review from
a team,
macbem and
quezak
as code owners
|
adiq
approved these changes
Feb 4, 2026
quezak
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Address GHSA-7h2j-956f-4vf2:
@isaacs/brace-expansion<= 5.0.0 is vulnerable to DoS via unbounded brace range expansion. Malicious patterns can cause exponential CPU/memory use and crash the Node.js process. The vulnerable package is used transitively in the dev/build toolchain (jest, metro, fsevents, node-gyp).Intended outcome
yarn installand native module builds use the patched@isaacs/brace-expansion@5.0.1.Overview of changes
"@isaacs/brace-expansion": "5.0.1"inpackage.json.yarn.lockso@isaacs/brace-expansionresolves to 5.0.1 instead of 5.0.0.Quality assurance
Completed by Cursor:
yarn install— completed successfullyyarn test— passedyarn typecheck— passedyarn prepare(bob build) — passed (commonjs, module, typescript)Risk: Low. Change is a patch-level upgrade within the existing semver range (
^5.0.0). No SDK release required; the fix only affects the repo's dev/build toolchain.