Skip to content

Conversation

@hugojosefson
Copy link

@hugojosefson hugojosefson commented May 1, 2020

This upgrades a bunch of dependencies, as well as makes make docker run both the build and the tests.

How to test

Building and testing in Docker

Needs only Docker installed, not Node.js.

make docker

Building and testing using Node.js

make && make check

    # or

npm install && npm test

I have successfully run the above commands using:

  • Docker version 19.03.8, build afacb8b7f0
  • Node.js v14.1.0
  • Node.js v12.16.3
  • Node.js v10.20.1
  • Node.js v8.17.0

I have not tested the results in an application, but am submitting my improvements here because of hugojosefson@0dbdf25#commitcomment-38849952.

Please test before merging :)

@hugojosefson
Copy link
Author

I notice now that .travis.yml specifies the old way of building and running tests, compatible with libvirt 3.6.0. Because I updated the tests to be compatible with libvirt 5.6.0, which works when building with Docker, the tests now fail in .travis.yml.

Unfortunately I don't have time to handle this, so @RamyElkest if you can find the time, please update .travis.yml to match what Dockerfile does if you want to merge this PR.

@RamyElkest
Copy link
Owner

@hugojosefson many thanks for taking the time.

The DockerFile was added recently so travis wasn't updated, I'll handle it.

Thanks again 👍

@hugojosefson
Copy link
Author

Thanks @RamyElkest 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants