feat: auto-instantiate type-annotated Config subclasses - #9
Closed
brian14708 wants to merge 1 commit into
Closed
brian14708 wants to merge 1 commit into
brian14708 wants to merge 1 commit into
Conversation
Extends Config initialization to automatically instantiate subclasses declared via type annotations (e.g., sub: SubConfig), not just direct assignments (e.g., sub = SubConfig). Type Safety Benefits: - 'sub = SubConfig' assigns the class itself, making type checkers infer type[SubConfig] (the class), breaking autocomplete and type checking - 'sub: SubConfig' declares an instance annotation, allowing type checkers to correctly infer SubConfig (an instance) for proper IDE support - This commit makes the type-safe pattern work at runtime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends Config initialization to automatically instantiate subclasses declared via type annotations (e.g., sub: SubConfig), not just direct assignments (e.g., sub = SubConfig).
Type Safety Benefits: