Skip to content

Fix doc builds#484

Merged
RandyGaul merged 2 commits into
RandyGaul:masterfrom
pusewicz:fix-doc-builds
Mar 1, 2026
Merged

Fix doc builds#484
RandyGaul merged 2 commits into
RandyGaul:masterfrom
pusewicz:fix-doc-builds

Conversation

@pusewicz
Copy link
Copy Markdown
Contributor

@pusewicz pusewicz commented Mar 1, 2026

Docs will be built on PRs, too. Just pushing the docs stays when marging to master.

Copilot AI review requested due to automatic review settings March 1, 2026 08:38
@pusewicz pusewicz mentioned this pull request Mar 1, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the documentation GitHub Actions workflow so documentation builds run for pull requests in addition to master pushes, helping catch doc build failures before merge.

Changes:

  • Trigger documentation workflow on pull_request events.
  • Install a specific CMake version (and Ninja) before running the docs build steps.
Comments suppressed due to low confidence (1)

.github/workflows/documentation.yml:26

  • Using floating versions here (lukka/get-cmake@latest and ninjaVersion: latest) makes the docs build non-reproducible and can break unexpectedly when upstream releases change; it also weakens the supply-chain security posture of the workflow. Prefer pinning the action to a tagged major/minor (or a commit SHA) and pin Ninja (or omit it if the runner-provided Ninja is sufficient).
        uses: lukka/get-cmake@latest
        with:
          cmakeVersion: 4.2.3
          ninjaVersion: latest

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

on:
push:
branches: [master]
pull_request:
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a pull_request trigger means the workflow will now run untrusted PR code with the current top-level permissions (pages: write, id-token: write). Those elevated permissions are only needed for the deploy job and increase the blast radius if a PR can execute arbitrary commands. Consider reducing the workflow-level permissions to read-only (e.g., contents: read) and granting pages: write / id-token: write only on the deploy job (and only on push to master).

Copilot uses AI. Check for mistakes.
@RandyGaul RandyGaul merged commit 5da337e into RandyGaul:master Mar 1, 2026
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants