Do not force ccache#491
Merged
Merged
Conversation
This allows users who do not want to use ccache to... not use it. We set it in the GitHub build action already.
Contributor
There was a problem hiding this comment.
Pull request overview
Removes automatic ccache detection/enabling from the project’s standard CMake settings so local builds don’t implicitly use ccache when it happens to be installed (while CI can continue to opt in via workflow configuration).
Changes:
- Deleted the
find_program(ccache)block that setCMAKE_C_COMPILER_LAUNCHER/CMAKE_CXX_COMPILER_LAUNCHER. - Leaves
compile_commands.jsongeneration behavior unchanged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows users who do not want to use ccache to... not use it. We set it in the GitHub build action already.