Improve Benchmarking

[JohnReedV]

Description

This PR

• Modifies the benchmark flow so that only extrinsics that have drifted passed the threshold or have incorrect read/writes are updated rather than replacing the entire file and creating conflicts everywhere.

• Adds a lint to check for extrinsics with missing benchmarks. This can be hidden with
  #[allow(unknown_lints, benchmarked_weight_not_plugged)]

• Adds 48 missing benchmarks

• Fixes a bug where benchmarks could fail on noisy internal component drift even when the actual benchmark-level weight was still within the configured threshold.

• Adds block_step & reveal_timelocked_commitments to the benchmark flow so the on_initialize weight is generated instead of hardcoded. The block_step benchmark simulates the current worst case with 2 epochs in a block.

• Updates the drift check to include proof size and to compare the actual benchmark-level weight instead of failing on noisy internal component drift.

[github-actions]

🛡️ AI Review — Skeptic (security review)

VERDICT: VULNERABLE

Baseline-to-medium scrutiny: established @opentensor-associated contributor; cached repo permission is read; no Gittensor allowlist hit found; branch apply-benchmark-to-only-bad-benches -> devnet-ready.

The PR does not modify .github/ai-review/* or .github/copilot-instructions.md. I did not find evidence of malicious intent, and the build-script/support-crate changes did not show network, credential, or shell-execution behavior under static review.

Findings

Sev	File	Finding
HIGH	pallets/commitments/src/lib.rs:346	Fixed hook weight still undercharges multiple timelock reveals	inline

Prior-comment reconciliation

• c42b31ce: not addressed — The current head adds the generated base weight plus dynamic DB weight, but the expensive per-timelock cryptographic reveal work is still charged only once.

Conclusion

The PR remains vulnerable because the timelocked-commitment hook can perform multiple expensive TLE decryptions from user-populated state while charging the generated CPU benchmark only once. The dynamic weight returned from reveal_timelocked_commitments() accounts for storage I/O, but not for per-timelock cryptographic work.

---

📜 Previous run (superseded)

Sev	File	Finding	Status
HIGH	pallets/commitments/src/lib.rs:346	Fixed hook weight still undercharges multiple timelock reveals	➡️ Carried forward to current findings The current head adds the generated base weight plus dynamic DB weight, but the expensive per-timelock cryptographic reveal work is still charged only once.

---

🔍 AI Review — Auditor (domain review)

VERDICT: 👍

Gittensor UNKNOWN; author is an established @opentensor/subtensor contributor with substantial recent PR history, cached repo permission is read.

PR body is substantive and matches the benchmark/tooling scope, so I would leave it unchanged.

The prior register_limit concern remains addressed: the benchmark still uses setup_full_subnet_registration_benchmark, fills the subnet, funds the caller, and dispatches against the replacement path rather than the cheap append path.

Duplicate-work check found overlapping PRs only through broad shared runtime, benchmark, and generated-weight files; none appear to be alternate implementations of this benchmark-flow change.

Validation performed: bash -n scripts/benchmark_action.sh, bash -n scripts/benchmark_all.sh, bash -n scripts/discover_pallets.sh, python3 -m py_compile scripts/benchmark_action.py, scripts/discover_pallets.sh, and git diff --check origin/devnet-ready...HEAD passed. Targeted Rust tests could not start because rustup attempted to create files under the read-only /home/runner/.rustup; live devnet spec_version comparison also could not complete because DNS resolution for dev.chain.opentensor.ai failed. No auto-fix changes were made.

Findings

No findings.

Prior-comment reconciliation

• 2caec2f2: addressed — register_limit still benchmarks through setup_full_subnet_registration_benchmark, filling the subnet before dispatch so the measured path reaches replacement rather than append.

Conclusion

I did not find a remaining domain issue that should block merge. CI should still perform the normal live spec-version and Rust test checks that this sandbox could not complete.

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

🔄 AI review updated — Skeptic: VULNERABLE

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
subtensor	Error		Jul 9, 2026 10:56pm

[github-actions]

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

[github-actions]

🔄 AI review updated — Skeptic: VULNERABLE

[github-actions]

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

[github-actions]

🔄 AI review updated — Skeptic: VULNERABLE

[github-actions]

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

[github-actions]

🔄 AI review updated — Skeptic: VULNERABLE