-
Notifications
You must be signed in to change notification settings - Fork 322
ci: path-filter heavy workflows + build-once/fan-out runtime checks #2852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -8,10 +8,34 @@ concurrency: | |||||||||||||
| group: e2e-cli-${{ github.ref }} | ||||||||||||||
| cancel-in-progress: true | ||||||||||||||
|
|
||||||||||||||
| # Path-filtered: none of this workflow's checks are required for merge, so a | ||||||||||||||
| # workflow-level `paths:` filter is safe. If any check here is ever made | ||||||||||||||
| # required, this filter MUST move to job-level `if:` gating (a required check | ||||||||||||||
| # whose workflow never triggers is stuck "Expected" and blocks the merge). | ||||||||||||||
| on: | ||||||||||||||
| pull_request: | ||||||||||||||
| branches: ["*"] | ||||||||||||||
| types: [opened, synchronize, reopened, labeled, unlabeled] | ||||||||||||||
| paths: | ||||||||||||||
| # Anything that changes the node/runtime the e2e suites run against. | ||||||||||||||
| - "common/**" | ||||||||||||||
| - "node/**" | ||||||||||||||
| - "pallets/**" | ||||||||||||||
| - "precompiles/**" | ||||||||||||||
| - "primitives/**" | ||||||||||||||
| - "runtime/**" | ||||||||||||||
| - "support/**" | ||||||||||||||
| - "chain-extensions/**" | ||||||||||||||
| - "src/**" | ||||||||||||||
| - "vendor/**" | ||||||||||||||
| - "Cargo.toml" | ||||||||||||||
| - "Cargo.lock" | ||||||||||||||
| - "build.rs" | ||||||||||||||
| - "rust-toolchain.toml" | ||||||||||||||
| - "Dockerfile-localnet" | ||||||||||||||
| # The SDK/CLI code under test. | ||||||||||||||
| - "sdk/**" | ||||||||||||||
| - ".github/workflows/check-bittensor-e2e-tests.yml" | ||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [HIGH] Executed scripts still bypass the e2e workflow filter This workflow checks out the PR and executes
Suggested change
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [HIGH] Executed scripts still bypass the e2e workflow filter This workflow later executes
Suggested change
|
||||||||||||||
|
|
||||||||||||||
| workflow_dispatch: | ||||||||||||||
| inputs: | ||||||||||||||
|
|
||||||||||||||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[HIGH] Executed scripts bypass the e2e workflow filter
This workflow later executes
scripts/install_build_env.sh,scripts/localnet_patch.sh, andscripts/localnet.shon a persistent self-hosted runner, but none matches this filter. A PR changing only one of those scripts will skip this workflow; the merged script can then execute during a later, unrelated nucleus-approved run. Add all directly executed scripts to the path set.