Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
99 changes: 0 additions & 99 deletions .github/actions/try-runtime/action.yml

This file was deleted.

20 changes: 0 additions & 20 deletions .github/scripts/check-skip-label.sh

This file was deleted.

24 changes: 24 additions & 0 deletions .github/workflows/check-bittensor-e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,34 @@ concurrency:
group: e2e-cli-${{ github.ref }}
cancel-in-progress: true

# Path-filtered: none of this workflow's checks are required for merge, so a
# workflow-level `paths:` filter is safe. If any check here is ever made
# required, this filter MUST move to job-level `if:` gating (a required check
# whose workflow never triggers is stuck "Expected" and blocks the merge).
on:
pull_request:
branches: ["*"]
types: [opened, synchronize, reopened, labeled, unlabeled]
paths:
# Anything that changes the node/runtime the e2e suites run against.
- "common/**"
- "node/**"
- "pallets/**"
- "precompiles/**"
- "primitives/**"
- "runtime/**"
- "support/**"
- "chain-extensions/**"
- "src/**"
- "vendor/**"
- "Cargo.toml"
- "Cargo.lock"
- "build.rs"
- "rust-toolchain.toml"
- "Dockerfile-localnet"
# The SDK/CLI code under test.
- "sdk/**"
- ".github/workflows/check-bittensor-e2e-tests.yml"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] Executed scripts bypass the e2e workflow filter

This workflow later executes scripts/install_build_env.sh, scripts/localnet_patch.sh, and scripts/localnet.sh on a persistent self-hosted runner, but none matches this filter. A PR changing only one of those scripts will skip this workflow; the merged script can then execute during a later, unrelated nucleus-approved run. Add all directly executed scripts to the path set.

Suggested change
- ".github/workflows/check-bittensor-e2e-tests.yml"
- "scripts/install_build_env.sh"
- "scripts/localnet_patch.sh"
- "scripts/localnet.sh"
- ".github/workflows/check-bittensor-e2e-tests.yml"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] Executed scripts still bypass the e2e workflow filter

This workflow checks out the PR and executes scripts/install_build_env.sh, scripts/localnet_patch.sh, and scripts/localnet.sh on self-hosted runners, but scripts/** is absent from the trigger paths. A script-only PR can merge without this workflow running, leaving its payload to execute later when an unrelated matching change triggers a nucleus-approved run. Include the executed scripts in the filter.

Suggested change
- ".github/workflows/check-bittensor-e2e-tests.yml"
- "scripts/**"
- ".github/workflows/check-bittensor-e2e-tests.yml"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] Executed scripts still bypass the e2e workflow filter

This workflow later executes scripts/install_build_env.sh, scripts/localnet_patch.sh, and scripts/localnet.sh on self-hosted runners, but scripts/** is absent from the trigger. A script-only PR can therefore merge without this workflow running, leaving the changed script to execute during a later nucleus-approved run whose unrelated diff matches this filter. Include every checked-out executable input in the path set.

Suggested change
- ".github/workflows/check-bittensor-e2e-tests.yml"
- "scripts/**"
- ".github/workflows/check-bittensor-e2e-tests.yml"


workflow_dispatch:
inputs:
Expand Down
159 changes: 0 additions & 159 deletions .github/workflows/check-clone-upgrade.yml

This file was deleted.

24 changes: 24 additions & 0 deletions .github/workflows/check-docker.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,31 @@
name: Docker Build Check

# Path-filtered: `docker build` is not a required merge check, so a
# workflow-level `paths:` filter is safe. If it is ever made required, this
# filter MUST move to job-level `if:` gating (a required check whose workflow
# never triggers is stuck "Expected" and blocks the merge).
on:
pull_request:
paths:
# Anything the Dockerfile's cargo build consumes.
- "common/**"
- "node/**"
- "pallets/**"
- "precompiles/**"
- "primitives/**"
- "runtime/**"
- "sdk/bittensor-core/**"
- "sdk/bittensor-core-py/**"
- "support/**"
- "chain-extensions/**"
- "src/**"
- "vendor/**"
- "Cargo.toml"
- "Cargo.lock"
- "build.rs"
- "rust-toolchain.toml"
- "Dockerfile"
- ".github/workflows/check-docker.yml"

concurrency:
group: check-docker-${{ github.ref }}
Expand Down
Loading
Loading