Fixes bug where "fitParams" outputs only one value #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexhroom
approved these changes
Dec 10, 2024
Collaborator
alexhroom
left a comment
alexhroom
left a comment
There was a problem hiding this comment.
works! note also that the single value of fitParams on main is the first value of the fitParams, so the fix definitely makes sense
alexhroom
added a commit
that referenced
this pull request
Dec 16, 2024
This reverts commit c7fb185.
DrPaulSharp
pushed a commit
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could you please confirm the following:
main, the results for the examples contains an arrayfitNamesof length >=1, and an arrayfitParamsof length 1.fitParamsis always the same as that offitNames.