backport: Use range-based for loops (C++11) when looping over map ele… #1172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments
manual backport of bitcoin #10493
picked: 680bc2cbb34d6bedd0e64b17d0555216572be4c8
Origial-author: practicalswift
Before this commit:
for (std::map<T1, T2>::iterator x = y.begin(); x != y.end(); ++x) {
}
After this commit:
for (auto& x : y) {
}
hans-schmidt
approved these changes
Jan 19, 2022
Contributor
hans-schmidt
left a comment
hans-schmidt
left a comment
There was a problem hiding this comment.
These changes are functionally identical to what bitcoin did. (There are two extra changes in wallet.cpp related to IsAssetScript, and some bracket reformatting).
This doesn't actually do anything except update some code to cleaner C++11 syntax.
Approved.
HyperPeek
approved these changes
Feb 8, 2022
Contributor
HyperPeek
left a comment
HyperPeek
left a comment
There was a problem hiding this comment.
approved, cleanup using c++11 features in loops with no functional change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ments
manual backport of bitcoin #10493
picked: 680bc2cbb34d6bedd0e64b17d0555216572be4c8
Origial-author: practicalswift
Before this commit:
for (std::map<T1, T2>::iterator x = y.begin(); x != y.end(); ++x) {
}
After this commit:
for (auto& x : y) {
}