Skip to content

feat: wire trade ticket to demo service - #10

Merged
RayLi-Muye merged 1 commit into
mainfrom
feat/9-ticket-demo-service-integration
Jun 18, 2026
Merged

RayLi-Muye merged 1 commit into
mainfrom
feat/9-ticket-demo-service-integration

Conversation

@RayLi-Muye

@RayLi-Muye RayLi-Muye commented Jun 18, 2026 •

Copy link
Copy Markdown
Owner

Linked Issue

Closes #9

Scope

  • Route existing trade ticket buy/sell actions through the local demo simulated trading service adapter.
  • Persist virtual-cash ledger entries in the demo portfolio store.
  • Expose the latest simulated ledger entry from the local hook.
  • Update trade ticket success feedback to say the fill is simulated and show the latest virtual ledger effect.
  • Update the web smoke test to wait for the simulated fill / virtual ledger confirmation and clear the ledger storage key.

Acceptance Criteria

  • Trade ticket buy/sell actions flow through the demo simulated trading service.
  • Virtual USD cash, holdings, and recent ledger entries update from the service result.
  • The user sees a minimal simulated/virtual ledger confirmation after a fill.
  • Existing insufficient cash / insufficient position behavior remains guarded.
  • No real broker, real order routing, provider API, API key, paid API, or credentialed API is introduced.
  • Local checks and CI pass.

Validation

  • npm ci
  • npm run check:simulated-trading
  • npm run typecheck
  • npm run check:market-data
  • npm run export:web
  • npm run verify:web-demo
  • git diff --check
  • GitHub Actions reviewed

Documentation Impact

  • None. This PR wires the already documented demo adapter into the local trade interaction path.

Risk / Rollback

  • Moderate risk: this touches the visible trade ticket path, but it remains local-only and is covered by the web smoke test.
  • Rollback by reverting this PR to restore the previous local portfolio mutation path.

Owner Decision Needs

  • None for this bounded routine maintenance PR.
  • Still out of scope without explicit authorization: production deploy, release/tag/package publish, real trading/order routing, sensitive credential/API key use, paid/credentialed API calls, destructive git operations, or major user-visible direction changes.

@vercel

vercel Bot commented Jun 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
demo-trading Ready Ready Preview, Comment Jun 18, 2026 3:58am

@RayLi-Muye
RayLi-Muye merged commit 4efd1ba into main Jun 18, 2026
3 checks passed

This branch was successfully deployed

1 active deployment
Preview — fb96115c Deployed Jun 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wire trade ticket to demo simulated trading service

1 participant