Skip to content

fix(project): increase remote image download limit to 30MB for legacy assets migration #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucas-matw-unq merged 1 commit into from
Oct 6, 2026
Merged

fix(project): increase remote image download limit to 30MB for legacy assets migration #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/module/project/project.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,11 +217,11 @@ export class ProjectService {
}

/**
* Downloads an image from an external HTTP/HTTPS URL with timeout and size cap (10MB).
* Downloads an image from an external HTTP/HTTPS URL with timeout and size cap (30MB).
*/
async fetchImageBuffer(
url: string,
timeoutMs = 8000,
timeoutMs = 20000,
): Promise<{ buffer: Buffer; mimetype: string }> {
return new Promise((resolve, reject) => {
const client = url.startsWith('https') ? https : http;
Expand Down Expand Up @@ -258,12 +258,12 @@ export class ProjectService {
const contentType = res.headers['content-type'] || 'image/jpeg';
const chunks: Buffer[] = [];
let totalLength = 0;
const maxBytes = 10 * 1024 * 1024; // 10MB limit
const maxBytes = 30 * 1024 * 1024; // 30MB limit

res.on('data', (chunk: Buffer) => {
totalLength += chunk.length;
if (totalLength > maxBytes) {
req.destroy(new Error('Image exceeds 10MB size limit'));
req.destroy(new Error('Image exceeds 30MB size limit'));
return;
}
chunks.push(chunk);
Expand Down
Loading