Mark Lost Aether Content as an explicit optional dependency.#345
Open
Acuadragon100 wants to merge 1 commit intoRazorDevs:1.20.1-1.1from
Open
Mark Lost Aether Content as an explicit optional dependency.#345Acuadragon100 wants to merge 1 commit intoRazorDevs:1.20.1-1.1from
Acuadragon100 wants to merge 1 commit intoRazorDevs:1.20.1-1.1from
Conversation
… Aether always loads after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deep Aether needs to load after Lost Aether Content to prevent the following crash:
It's just that there isn't really anything making sure Deep Aether always loads after Lost Aether Content at the moment. The mod id for Lost Aether Content just happens to end up before Deep Aether's mod id in a hash map used to check for mod duplicates during the startup process.
As you can probably imagine, that's quite brittle. So I thought it would be a good idea to add it as an explicit optional dependency to mods.toml. That way Forge will make sure Lost Aether Content is always the first to load, avoiding the crash.
As far as I can tell this only affects 1.20.1 for now.