Skip to content

fix(release): honor .extensionignore in extension packaging#10

Merged
RbBtSn0w merged 2 commits into
mainfrom
fix/release-package-respect-extensionignore
May 27, 2026
Merged

fix(release): honor .extensionignore in extension packaging#10
RbBtSn0w merged 2 commits into
mainfrom
fix/release-package-respect-extensionignore

Conversation

@RbBtSn0w
Copy link
Copy Markdown
Owner

Summary

  • update release packaging step to honor each extension's .extensionignore
  • switch zip assembly to a staging-copy flow using GitIgnore-compatible matching via pathspec
  • keep package artifacts clean by excluding .extensionignore itself and preserving legacy __pycache__/ exclusion
  • add release-workflow regression checks to guard .extensionignore and pathspec usage

Validation

  • bash tests/test-release-workflow.sh
  • bash tests/test-review-regressions.sh
  • ruby -e "require 'yaml'; YAML.load_file('.github/workflows/ci.yml'); YAML.load_file('.github/workflows/release-trigger.yml')"
  • git diff --check

Notes

  • pwsh -File superpowers-bridge/tests/test-status-sync.ps1 was not runnable in this environment because pwsh is not installed.

Copilot AI review requested due to automatic review settings May 27, 2026 13:50
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the release workflow tests in tests/test-release-workflow.sh by adding two new validation checks. These checks ensure that the release trigger honors .extensionignore during zip assembly and uses pathspec-compatible ignore matching during packaging. There are no review comments to address, and I have no additional feedback to provide.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the release-trigger workflow so extension zip artifacts are assembled from a staging directory while honoring each extension’s .extensionignore rules (via pathspec), and adds a regression check to ensure those workflow requirements remain in place.

Changes:

  • Replace direct zip -r packaging with a staging-copy flow that filters files using pathspec GitIgnore-style matching.
  • Ensure .extensionignore and legacy __pycache__/ excludes are applied during packaging.
  • Extend the release-workflow regression test to assert .extensionignore + pathspec usage in the release trigger workflow.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
tests/test-release-workflow.sh Adds regression checks ensuring the release workflow continues to honor .extensionignore and uses pathspec.
.github/workflows/release-trigger.yml Reworks “Create extension zip” to stage filtered files (using .extensionignore) before zipping, installing pathspec at runtime.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/release-trigger.yml Outdated
Comment thread .github/workflows/release-trigger.yml Outdated
Comment thread .github/workflows/release-trigger.yml
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b6a94a1668

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/release-trigger.yml Outdated
@RbBtSn0w RbBtSn0w merged commit e6007f3 into main May 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants