fix(release): honor .extensionignore in extension packaging#10
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the release workflow tests in tests/test-release-workflow.sh by adding two new validation checks. These checks ensure that the release trigger honors .extensionignore during zip assembly and uses pathspec-compatible ignore matching during packaging. There are no review comments to address, and I have no additional feedback to provide.
There was a problem hiding this comment.
Pull request overview
Updates the release-trigger workflow so extension zip artifacts are assembled from a staging directory while honoring each extension’s .extensionignore rules (via pathspec), and adds a regression check to ensure those workflow requirements remain in place.
Changes:
- Replace direct
zip -rpackaging with a staging-copy flow that filters files usingpathspecGitIgnore-style matching. - Ensure
.extensionignoreand legacy__pycache__/excludes are applied during packaging. - Extend the release-workflow regression test to assert
.extensionignore+pathspecusage in the release trigger workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/test-release-workflow.sh | Adds regression checks ensuring the release workflow continues to honor .extensionignore and uses pathspec. |
| .github/workflows/release-trigger.yml | Reworks “Create extension zip” to stage filtered files (using .extensionignore) before zipping, installing pathspec at runtime. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6a94a1668
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
.extensionignorepathspec.extensionignoreitself and preserving legacy__pycache__/exclusion.extensionignoreandpathspecusageValidation
bash tests/test-release-workflow.shbash tests/test-review-regressions.shruby -e "require 'yaml'; YAML.load_file('.github/workflows/ci.yml'); YAML.load_file('.github/workflows/release-trigger.yml')"git diff --checkNotes
pwsh -File superpowers-bridge/tests/test-status-sync.ps1was not runnable in this environment becausepwshis not installed.