feat(memorylint): close audit/apply loop#11
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request introduces workspace-level helper scripts (audit_workspace.py, apply_report.py, and load_agents_state.py) powered by a shared core module (memorylint_core.py) to unify instruction drift detection and safe-apply workflows. It also updates the documentation, regression fixtures, and test suites to support the new executable report schema and canonical ownership matrix. The review feedback focuses on enhancing the portability, robustness, and performance of the Python scripts. Key recommendations include adding a --workspace CLI override to support portable execution, replacing inline __import__ calls with standard top-level imports, optimizing an package.json files gracefully to prevent crashes, and enforcing workspace-only scope checks to mitigate directory traversal risks.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR turns MemoryLint into an executable audit/apply workflow by adding a shared Python core, workspace/report helper scripts, structured load-agents proof output, and expanded contracts/docs/tests.
Changes:
- Adds
memorylint_core.pyplus audit/apply/load-agents CLIs. - Refactors fixture scanning onto the shared audit core and updates expected findings.
- Expands command docs, README/DESIGN, changelog, and regression tests for the new executable contracts.
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
memorylint/scripts/memorylint_core.py |
Adds shared audit/apply logic, report schema, edits, handoffs, validators. |
memorylint/scripts/audit_workspace.py |
Adds workspace audit CLI. |
memorylint/scripts/apply_report.py |
Adds report apply CLI with staleness checks and rollback. |
memorylint/scripts/load_agents_state.py |
Adds structured AGENTS.md load proof CLI. |
memorylint/scripts/scan_fixtures.py |
Refactors fixture scanner to use the shared core. |
memorylint/tests/test-workspace-audit.sh |
Adds workspace audit end-to-end checks. |
memorylint/tests/test-apply-workflow.sh |
Adds apply, staleness, and rollback checks. |
memorylint/tests/test-load-agents-proof.sh |
Adds structured load-agents proof checks. |
memorylint/tests/test-memorylint-regressions.sh |
Extends contract checks for scripts/docs/tests. |
memorylint/tests/fixtures/*/expected-findings.json |
Updates fixture expectations for shared-core output. |
memorylint/tests/fixtures/monorepo-nested/packages/frontend/package.json |
Adds package metadata for nested fixture coverage. |
memorylint/commands/audit.md |
Documents executable audit/report/edit/handoff contract. |
memorylint/commands/apply.md |
Documents apply modes, validation, rollback, and handoff protocol. |
memorylint/commands/load-agents.md |
Documents structured before-plan proof output. |
memorylint/README.md |
Updates user-facing MemoryLint behavior and metrics. |
memorylint/DESIGN.md |
Updates architecture/design contract for executable workflow. |
memorylint/CHANGELOG.md |
Records unreleased MemoryLint additions and changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7856886442
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8f7e9ef0b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b3e89da836
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d7e392867
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary
Checklist closure
Validation
Notes
pwsh -File superpowers-bridge/tests/test-status-sync.ps1was skipped per user instruction; rely on CI for that coverage