Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends ARC’s harmonic frequency scaling-factor database with additional solvent-phase (SMD/DMSO) entries and enhances runtime logging to report where the chosen scaling factor came from.
Changes:
- Added new frequency scaling factors to
data/freq_scale_factors.ymlfor several levels of theory, including SMD/DMSO cases and additional basis variants. - Updated
ARC.check_freq_scaling_factor()to log the scaling factor along with its source (user input, database, Truhlar’s method, or fallback).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| data/freq_scale_factors.yml | Adds new scaling-factor entries (including solvent-phase variants) to the lookup database. |
| arc/main.py | Improves observability by logging the scaling factor value and its provenance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@Lilachn91 looks good! Can you just do the fix mentioned by ChatGPT and consolidate the commits |
calvinp0
left a comment
There was a problem hiding this comment.
Just need some changes, as mentioned
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #834 +/- ##
==========================================
- Coverage 58.69% 58.67% -0.02%
==========================================
Files 97 97
Lines 29197 29203 +6
Branches 7752 7752
==========================================
Hits 17136 17136
- Misses 9865 9868 +3
- Partials 2196 2199 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
22ffe02 to
580ef15
Compare
Recalculated 'wb97xd/aug-cc-pvtz', gas
580ef15 to
bf4b963
Compare
Added calculated frequency scale factors for several levels of theory in solvent, using SMD.
Also, since for some LoTs the database includes calculated scale factors with and without solvation, arc will report in the log file where the scaling factor was taken from, and what is its value.