Skip to content

Scale factor smd#834

Open
Lilachn91 wants to merge 2 commits intomainfrom
scale_factor_SMD
Open

Scale factor smd#834
Lilachn91 wants to merge 2 commits intomainfrom
scale_factor_SMD

Conversation

@Lilachn91
Copy link
Contributor

Added calculated frequency scale factors for several levels of theory in solvent, using SMD.
Also, since for some LoTs the database includes calculated scale factors with and without solvation, arc will report in the log file where the scaling factor was taken from, and what is its value.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends ARC’s harmonic frequency scaling-factor database with additional solvent-phase (SMD/DMSO) entries and enhances runtime logging to report where the chosen scaling factor came from.

Changes:

  • Added new frequency scaling factors to data/freq_scale_factors.yml for several levels of theory, including SMD/DMSO cases and additional basis variants.
  • Updated ARC.check_freq_scaling_factor() to log the scaling factor along with its source (user input, database, Truhlar’s method, or fallback).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
data/freq_scale_factors.yml Adds new scaling-factor entries (including solvent-phase variants) to the lookup database.
arc/main.py Improves observability by logging the scaling factor value and its provenance.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@calvinp0
Copy link
Member

@Lilachn91 looks good! Can you just do the fix mentioned by ChatGPT and consolidate the commits

Copy link
Member

@calvinp0 calvinp0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need some changes, as mentioned

@codecov
Copy link

codecov bot commented Mar 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.67%. Comparing base (0c6e7c5) to head (bf4b963).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #834      +/-   ##
==========================================
- Coverage   58.69%   58.67%   -0.02%     
==========================================
  Files          97       97              
  Lines       29197    29203       +6     
  Branches     7752     7752              
==========================================
  Hits        17136    17136              
- Misses       9865     9868       +3     
- Partials     2196     2199       +3     
Flag Coverage Δ
functionaltests 58.67% <ø> (-0.02%) ⬇️
unittests 58.67% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Lilachn91 Lilachn91 requested a review from calvinp0 March 22, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants