Improve test suite for single and Singles#223
Open
Korpen wants to merge 3 commits intoReactiveX:2.xfrom
Open
Conversation
Collaborator
|
Hi @Korpen, To make the Travis build pass, you should pull upstream 2.x branch again. There was a change in Travis configuration. (oraclejdk8 license was changed and it stopped working, so we switched to openjdk8). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous test suite for extension functions of single and the Singles singleton was leaving a lot to be desired. This PR introduces tests that check that any extension function or method behave the same as the RxJava equivalent.