Conversation
* part-1: Deployment tune up
Part 2 rak review
* master: Correct kill command Add but Correct PROJECTID export. Add references to the docker images on docker hub Update docker commands
njoyce
approved these changes
Oct 4, 2017
njoyce
left a comment
njoyce
left a comment
Contributor
There was a problem hiding this comment.
Looks really good - a couple of comments about links to documentation.
| account = email.address@somedomain.com | ||
| project = your-google-cloud-project-id | ||
|
|
||
| I recommend setting both your project and compute zone. You can find the directions for both in the Google Cloud Tools Documentation. |
Contributor
There was a problem hiding this comment.
I think we should add a link to this - perhaps https://cloud.google.com/compute/docs/regions-zones/changing-default-zone-region
|
|
||
| Now let's deploy some pods. First we need to ensure our `kubectl` command is pointing at our cluster. If you run the following command you should see a list of contexts: | ||
|
|
||
| $ kubectl config get-clusters |
Contributor
There was a problem hiding this comment.
Do we need to run https://cloud.google.com/sdk/gcloud/reference/container/clusters/get-credentials before this?
Assorted updates
Last round of tweaks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.