Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of
"/api/test"toEXCLUDED_PATHScombined with thestartsWithmatching logic in theshouldNotFiltermethod (line 113) creates a security vulnerability. This causes the JWT authentication filter to be skipped for any request URI starting with"/api/test", inadvertently including the protected/api/test-authendpoint. Consequently, legitimate authenticated requests to/api/test-authreceive a401 Unauthorizederror, breaking access to protected test endpoints. This also highlights a broader maintainability issue: theEXCLUDED_PATHSlist duplicates and is inconsistent withSecurityConfig'sPERMIT_ALL_URL_ARRAY. For example, paths like/api/v1/tags/**and/api/v1/auth/signuparepermitAllinSecurityConfigbut are missing fromEXCLUDED_PATHS, potentially leading to incorrect JWT authentication requirements. It is strongly recommended to use a more precise matching mechanism, such asequals()for exact matches or Spring'sAntPathMatcherfor pattern matching, to ensure only intended paths are excluded. For a more robust solution, consider refactoring to manage all security configurations in a single place, perhaps usingWebSecurityCustomizerinSecurityConfigto completely bypass the filter chain for ignored paths, makingEXCLUDED_PATHSunnecessary.