feat(games): add Rapport model as typed atomic entry for Report#69
Open
RebelliousSmile wants to merge 1 commit intomainfrom
Open
feat(games): add Rapport model as typed atomic entry for Report#69RebelliousSmile wants to merge 1 commit intomainfrom
RebelliousSmile wants to merge 1 commit intomainfrom
Conversation
Introduces Rapport — the atomic narrative element composing a Report. Each Rapport has a fixed type (description, action, discussion, narration); discussion type requires an existing Character as actor. - Model: Rapport(BaseModel) with RapportKind choices, clean() bidirectional validation (actor required for discussion, forbidden otherwise), migration 0010 - Admin: RapportInline on ReportAdmin - Form: RapportForm with actor queryset scoped to report's game - Views: rapport_create (GET+POST), rapport_edit, rapport_delete with HTMX partials - Templates: rapport_form.html (Alpine.js conditional actor), rapport_item.html (HTMX swap delete), report_detail.html updated with rapports section - Tests: 13 tests covering model validation and view access control - i18n: .po/.mo updated for fr/en Closes #64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rapport— the atomic narrative element composing aReport, with four fixed types: description, action, discussion, narrationdiscussiontype requires an existingCharacteras actor; all other types forbid actor — validated inRapport.clean()bidirectionallyChanges
Rapport(BaseModel)withRapportKindchoices,clean()validation, migration0010RapportInlineonReportAdminRapportFormwith actor queryset scoped to the report's gamerapport_create(GET+POST),rapport_edit,rapport_delete— all guarded byreport.author == request.userrapport_form.html(Alpine.js conditional actor + help link when no characters),partials/rapport_item.html(HTMX swap delete),report_detail.htmlupdated.po/.moupdated for fr/enTest plan
make check→ 271 passed, mypy clean, ruff cleanCloses #64
🤖 Generated with Claude Code