fix: disable ssh multiplex on native Windows#20
Merged
Conversation
Banner-based detection in v0.11.29 still leaves multiplex enabled for the very Microsoft OpenSSH it tried to skip — Jorma reports ongoing `mux_client_request_session: read from master failed: Connection reset by peer` and `ControlSocket ... already exists, disabling multiplexing` mid-fetch. Per Jorma's instruction, drop detection and disable multiplex on native Windows entirely. WSL, Cygwin and Git-Bash run as Linux from Python's POV (System.windows is False) so they keep multiplex. Also drops merge_stderr from execute_piped — added in #19 only for the now-removed `ssh -V` banner probe, no other callers.
RedFox20
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
System.windows == True)System.windows == False)merge_stderrparameter fromexecute_pipedWhy
After #19 / v0.11.29, Jorma still saw on Windows:
The
OpenSSH_for_Windows_<ver>banner heuristic isn't catching every broken-mux configuration in practice. Per Jorma's instruction: "If you can't figure this out, just disable ssh mux entirely on Windows (natively only, wsl is probably fine)."Test plan
pytest tests/test_ssh_multiplex/— 38 passed_version.pyto 0.11.30 to trigger deploy on merge🤖 Generated with Claude Code