Skip to content

Update dependency node to v22.23.2 - #4791

Merged
g-duval merged 1 commit into
masterfrom
konflux/mintmaker/master/node-22.x
Aug 5, 2026
Merged

Update dependency node to v22.23.2#4791
g-duval merged 1 commit into
masterfrom
konflux/mintmaker/master/node-22.x

Conversation

@red-hat-konflux

@red-hat-konflux red-hat-konflux Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Type Update Change
node uses-with minor 22.20.022.23.2

Release Notes

actions/node-versions (node)

v22.23.2: 22.23.2

Compare Source

Node.js 22.23.2

v22.23.1: 22.23.1

Compare Source

Node.js 22.23.1

v22.23.0: 22.23.0

Compare Source

Node.js 22.23.0

v22.22.3: 22.22.3

Compare Source

Node.js 22.22.3

v22.22.2: 22.22.2

Compare Source

Node.js 22.22.2

v22.22.1: 22.22.1

Compare Source

Node.js 22.22.1

v22.22.0: 22.22.0

Compare Source

Node.js 22.22.0

v22.21.1: 22.21.1

Compare Source

Node.js 22.21.1

v22.21.0: 22.21.0

Compare Source

Node.js 22.21.0


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The Mintmaker lockfile-refresh workflow now provisions Node.js 22.23.2 instead of 22.20.0.

Changes

Mintmaker workflow

Layer / File(s) Summary
Node.js version update
.github/workflows/build.yml
The lockfile-refresh setup now uses Node.js 22.23.2.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: g-duval

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the Node.js dependency update to version 22.23.2.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch konflux/mintmaker/master/node-22.x

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/build.yml (1)

106-111: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Update admin-console/pom.xml to match the new Node.js version.

The comment at Line 107 states the Node.js version must stay in sync with <nodeVersion> in admin-console/pom.xml. This PR updates node-version to 22.23.2 here, but admin-console/pom.xml still specifies v22.20.0. Update admin-console/pom.xml in the same change to keep the two files consistent.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/build.yml around lines 106 - 111, Update the <nodeVersion>
value in admin-console/pom.xml to 22.23.2 so it matches the node-version
configured in the “Set up Node for Mintmaker lockfile refresh” workflow step.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In @.github/workflows/build.yml:
- Around line 106-111: Update the <nodeVersion> value in admin-console/pom.xml
to 22.23.2 so it matches the node-version configured in the “Set up Node for
Mintmaker lockfile refresh” workflow step.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f0e7a13c-a302-4240-bd4d-1214f7ffb997

📥 Commits

Reviewing files that changed from the base of the PR and between 18eda66 and 068099c.

📒 Files selected for processing (1)
  • .github/workflows/build.yml

@larrymou9

Copy link
Copy Markdown
Collaborator

Performance Tests failed

PR #4791
Branch konflux/mintmaker/master/node-22.x
SHA 068099ceae454fdb0b26dddd56f6aa41ba73911f
Build #105
Image tested quay.io/redhat-user-workloads/hcc-integrations-tenant/notifications/notifications-backend:on-pr-068099ceae454fdb0b26dddd56f6aa41ba73911f

Tests run: InsightsNotificationswebhook_runner · InsightsNotificationsgw_runner · InsightsNotificationsemail_runner

📊 Performance Results

InsightsNotificationsemail_runner

Metric Result Value Min Max
notifications-engine-service.restarts.sum ✅ PASS 0.000 0.000 0.000
notifications-connector-email-service.restarts.sum ✅ PASS 0.000 0.000 0.000
SUMMARY.total_rps ❌ FAIL 13.817 13.966 14.498
SUMMARY.median_response_time ✅ PASS 11.000 10.000 12.000
POST_notifications.avg_response_time ❌ FAIL 32.543 25.972 30.650
SUMMARY.num_failures ✅ PASS 0.000 0.000 0.000
SUMMARY.fail_ratio ✅ PASS 0.000 0.000 0.000

InsightsNotificationswebhook_runner

Metric Result Value Min Max
notifications-engine-service.restarts.sum ✅ PASS 0.000 0.000 0.000
notifications-connector-webhook-service.restarts.sum ✅ PASS 0.000 0.000 0.000
results.created_at.duration_stats.mean ❌ FAIL 155.704 141.021 154.384
results.created_at.duration_stats.median ❌ FAIL 170.773 152.376 170.057
results.created_at.rps_stats.mean ✅ PASS 3.609 3.240 3.678
results.created_at.rps_stats.median ❌ FAIL 2.800 2.900 3.200

InsightsNotificationsgw_runner

Metric Result Value Min Max
notifications-engine-service.restarts.sum ✅ PASS 0.000 0.000 0.000
notifications-gw-service.restarts.sum ✅ PASS 0.000 0.000 0.000
SUMMARY.total_rps ✅ PASS 14.449 14.105 14.599
SUMMARY.median_response_time ✅ PASS 12.000 10.000 12.000
POST_notifications.avg_response_time ✅ PASS 26.071 24.871 29.947
SUMMARY.num_failures ✅ PASS 0.000 0.000 0.000
SUMMARY.fail_ratio ✅ PASS 0.000 0.000 0.000

@g-duval g-duval left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@g-duval
g-duval merged commit 2ea9885 into master Aug 5, 2026
56 of 57 checks passed
@g-duval
g-duval deleted the konflux/mintmaker/master/node-22.x branch August 5, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants