Skip to content

fix(eventlog): Fix the email and drawer action recipients popup - #1053

Merged
InsaneZein merged 1 commit into
RedHatInsights:masterfrom
InsaneZein:fix-recipient-actions
Aug 19, 2026
Merged

fix(eventlog): Fix the email and drawer action recipients popup#1053
InsaneZein merged 1 commit into
RedHatInsights:masterfrom
InsaneZein:fix-recipient-actions

Conversation

@InsaneZein

@InsaneZein InsaneZein commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Description

  • Display the real recipient count from the backend's new recipient_count field in the action popover
  • Remove the misleading "Users: All" / "X emails sent" labels
  • remove the extra GET /endpoints/{id} that was previously used

RHCLOUD-39779


Screenshots

Screenshot From 2026-08-18 11-28-48

Checklist ☑️

  • PR only fixes one issue or story
  • Change reviewed for extraneous code
  • UI best practices adhered to
  • Commits squashed and meaningfully named
  • All PR checks pass locally (build, lint, test, E2E)

  • (Optional) QE: Needs QE attention (OUIA changed, perceived impact to tests, no test coverage)
  • (Optional) QE: Has been mentioned
  • (Optional) UX: Needs UX attention (end user UX modified, missing designs)
  • (Optional) UX: Has been mentioned

@InsaneZein
InsaneZein requested a review from a team as a code owner August 18, 2026 16:29
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: feca231d-df30-4667-8680-d493e1d040e9

📥 Commits

Reviewing files that changed from the base of the PR and between 01bf71b and 6e4d601.

📒 Files selected for processing (9)
  • src/components/Notifications/EventLog/EventLogActionPopoverContent.tsx
  • src/components/Notifications/EventLog/EventLogTable.tsx
  • src/components/Notifications/EventLog/EventLogToolbar.stories.tsx
  • src/components/Notifications/EventLog/__tests__/EventLogTable.test.tsx
  • src/pages/Notifications/EventLog/EventLogPage.tsx
  • src/types/Event.ts
  • src/types/Integration.ts
  • src/types/adapters/NotificationEventAdapter.ts
  • src/types/adapters/__tests__/NotificationEventAdapter.test.ts
💤 Files with no reviewable changes (4)
  • src/types/Integration.ts
  • src/pages/Notifications/EventLog/EventLogPage.tsx
  • src/components/Notifications/EventLog/tests/EventLogTable.test.tsx
  • src/components/Notifications/EventLog/EventLogToolbar.stories.tsx

Included review availability: Your plan includes up to 12 reviews per rolling hour; 11 remain after this review.


Summary by CodeRabbit

  • New Features
    • Event log actions now display recipient counts directly.
    • Grouped actions retain the latest available recipient count.
  • Bug Fixes
    • Error summaries now consistently display failed counts.
    • Recipient counts are handled correctly when unavailable or missing.
  • Tests
    • Added coverage for recipient count mapping, missing values, and grouped actions.

Walkthrough

The event log now receives recipients_count from the event adapter and displays it in action popovers. Integration-recipient lookup logic, props, types, loading states, and related wiring were removed.

Changes

Event log recipient counts

Layer / File(s) Summary
Recipient count contract and adapter
src/types/Event.ts, src/types/Integration.ts, src/types/adapters/NotificationEventAdapter.ts, src/types/adapters/__tests__/NotificationEventAdapter.test.ts
NotificationEventAction now includes an optional recipientsCount. The adapter maps and groups server recipient counts. Tests cover populated, missing, null, and grouped values.
Remove recipient lookup wiring
src/pages/Notifications/EventLog/EventLogPage.tsx, src/components/Notifications/EventLog/EventLogTable.tsx, src/components/Notifications/EventLog/EventLogToolbar.stories.tsx
The event log page, table, and story no longer define or pass integration-recipient lookup callbacks.
Display recipient counts
src/components/Notifications/EventLog/EventLogActionPopoverContent.tsx
The popover displays a Recipients column from recipientsCount, removes lookup states, and reports error counts as failed.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 6e4d6

This change updates event log action popovers to show backend-provided recipient counts and removes an unnecessary endpoint request; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: platex-rehor-bot, aferd

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change to the email and drawer action recipients popup.
Description check ✅ Passed The description summarizes the UI and request changes, links the tracked issue, and includes a relevant screenshot.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

@InsaneZein
InsaneZein merged commit 79a6b28 into RedHatInsights:master Aug 19, 2026
11 checks passed
@InsaneZein
InsaneZein deleted the fix-recipient-actions branch August 19, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants