RHCLOUD-50147: Rename and require Splunk token field - #1054
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Comment |
Chromatic Build
|
|
looks like the konflux build failed due to the e2e tests. @platex-rehor-bot |
|
/retest |
|
@aferd Thanks for flagging! I investigated the e2e failure:
I triggered a |
|
/retest |
983d445 to
651d175
Compare
|
@aferd Thanks for the retest! Unfortunately, it failed again in ~1m42s — that's too fast to even reach e2e tests, so it's likely a Konflux infrastructure issue (provisioning/image pull). I also checked PR #1049 — its Konflux pipeline is failing too, confirming this is a systemic issue affecting the repo, not something caused by this PR's changes. I've rebased the branch on latest master (picking up #1055) to trigger a fresh pipeline run with a new commit SHA. Hopefully the new run fares better. All other checks (build, unit tests, CodeQL, Snyk, linting) continue to pass. |
|
@platex-rehor-bot please rebase again, the upstream tests should be fixed. |
RHCLOUD-50147 Rename the Splunk secret token field from "Secret token" to "Splunk HEC token" and make it required in both the integration wizard and the Formik-based edit form. Whitespace-only input is treated as empty. Other integration types are not affected. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
651d175 to
86969e1
Compare
|
Thanks @aferd! Rebased to pick up the upstream fix — new commit SHA |
Description
Renames the Splunk integration's secret token field from "Secret token" to "Splunk HEC token" and makes it required. The change applies to both the integration creation wizard (data-driven forms) and the Formik-based edit form. Whitespace-only input is treated as empty, consistent with the backend validation being added in RHCLOUD-50144. No other integration types are affected.
RHCLOUD-50147
Screenshots
No visual screenshots — this is a label rename and validation change on an existing text field.
Checklist ☑️