Skip to content

RHCLOUD-50147: Rename and require Splunk token field - #1054

Merged
aferd merged 1 commit into
RedHatInsights:masterfrom
platex-rehor-bot:bot/RHCLOUD-50147
Aug 26, 2026
Merged

RHCLOUD-50147: Rename and require Splunk token field#1054
aferd merged 1 commit into
RedHatInsights:masterfrom
platex-rehor-bot:bot/RHCLOUD-50147

Conversation

@platex-rehor-bot

@platex-rehor-bot platex-rehor-bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Description

Renames the Splunk integration's secret token field from "Secret token" to "Splunk HEC token" and makes it required. The change applies to both the integration creation wizard (data-driven forms) and the Formik-based edit form. Whitespace-only input is treated as empty, consistent with the backend validation being added in RHCLOUD-50144. No other integration types are affected.

RHCLOUD-50147


Screenshots

No visual screenshots — this is a label rename and validation change on an existing text field.


Checklist ☑️

  • PR only fixes one issue or story
  • Change reviewed for extraneous code
  • UI best practices adhered to
  • Commits squashed and meaningfully named
  • All PR checks pass locally (build, lint, test, E2E)

  • (Optional) QE: Needs QE attention (OUIA changed, perceived impact to tests, no test coverage)
  • (Optional) QE: Has been mentioned
  • (Optional) UX: Needs UX attention (end user UX modified, missing designs)
  • (Optional) UX: Has been mentioned

@platex-rehor-bot
platex-rehor-bot requested a review from a team as a code owner August 20, 2026 15:11
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b1ba9126-925c-4e01-8c47-906931a9908c


Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown

@aferd

aferd commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

looks like the konflux build failed due to the e2e tests. @platex-rehor-bot

@platex-rehor-bot

Copy link
Copy Markdown
Contributor Author

/retest

@platex-rehor-bot

Copy link
Copy Markdown
Contributor Author

@aferd Thanks for flagging! I investigated the e2e failure:

  • Not caused by this PR — none of the Playwright specs test Splunk integration creation. The PR only changes the Splunk token field label/validation in the wizard and Formik form.
  • Build passes — verified locally with npm ci + npm run build (the committed lockfile correctly includes all deps).
  • Unit tests pass — all 96 integration-related tests pass, including the 7 new schema validation tests.
  • Likely flaky — PR feat(RHCLOUD-50186): Adopt isKesselEnabled for v1/v2 permission detection #1052 (same master, same .tekton config, same set of specs) passed e2e. The pipeline runs all 7 Playwright specs with 180s timeout and 2 retries, and module federation navigation can be slow in Konflux.

I triggered a /retest to retry the pipeline. If it fails again, I can investigate which specific spec is failing (Konflux logs returned 401 this cycle, so I couldn't read the failure details).

@aferd

aferd commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

/retest

@platex-rehor-bot

Copy link
Copy Markdown
Contributor Author

@aferd Thanks for the retest! Unfortunately, it failed again in ~1m42s — that's too fast to even reach e2e tests, so it's likely a Konflux infrastructure issue (provisioning/image pull).

I also checked PR #1049 — its Konflux pipeline is failing too, confirming this is a systemic issue affecting the repo, not something caused by this PR's changes.

I've rebased the branch on latest master (picking up #1055) to trigger a fresh pipeline run with a new commit SHA. Hopefully the new run fares better. All other checks (build, unit tests, CodeQL, Snyk, linting) continue to pass.

@aferd

aferd commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

@platex-rehor-bot please rebase again, the upstream tests should be fixed.

RHCLOUD-50147
Rename the Splunk secret token field from "Secret token" to
"Splunk HEC token" and make it required in both the integration
wizard and the Formik-based edit form. Whitespace-only input is
treated as empty. Other integration types are not affected.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@platex-rehor-bot

Copy link
Copy Markdown
Contributor Author

Thanks @aferd! Rebased to pick up the upstream fix — new commit SHA 86969e1. Fresh Konflux pipeline should be triggered now. 🤞

@aferd
aferd merged commit 4e2c1ab into RedHatInsights:master Aug 26, 2026
10 checks passed
@platex-rehor-bot
platex-rehor-bot deleted the bot/RHCLOUD-50147 branch August 26, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants