RHINENG-25948: add ff for refreshing advisory cache - #2167
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a feature-flag-controlled gate around advisory cache refresh in the vmaas sync task, defaulting to enabled via pod configuration. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="tasks/vmaas_sync/vmaas_sync.go" line_range="115-122" />
<code_context>
// refresh caches
- caches.RefreshAdvisoryCaches()
+ if tasks.EnableAdvisoryCacheRefresh {
+ caches.RefreshAdvisoryCaches()
+ } else {
+ utils.LogInfo("Advisory cache refresh is disabled")
+ }
</code_context>
<issue_to_address>
**suggestion:** Consider lowering the log level or throttling the "cache refresh disabled" message to avoid log noise.
Because `SyncData` may be called frequently, this `LogInfo` will be emitted on every call while advisory refresh is disabled, creating excessive log noise. Consider downgrading to debug level or logging this only once (e.g., on first evaluation of the flag) instead of on every invocation.
```suggestion
// refresh caches
if tasks.EnableAdvisoryCacheRefresh {
caches.RefreshAdvisoryCaches()
} else {
utils.LogDebug("Advisory cache refresh is disabled")
}
utils.LogInfo("Data sync finished successfully")
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2167 +/- ##
==========================================
- Coverage 59.11% 59.10% -0.01%
==========================================
Files 134 134
Lines 8741 8744 +3
==========================================
+ Hits 5167 5168 +1
- Misses 3031 3032 +1
- Partials 543 544 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MichaelMraka
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a feature flag to enable/disable refreshing of advisory caches in vmaas sync task. Defaults to enabled.
Summary by Sourcery
Enhancements: