fix(deps): resolve transitive vulnerabilities and clean Dockerfile - #288
fix(deps): resolve transitive vulnerabilities and clean Dockerfile#288platex-rehor-bot wants to merge 3 commits into
Conversation
RHCLOUD-46715 Run npm audit fix to upgrade transitive deps flagged by grype scan: braces, immutable, launch-editor, flatted, fast-uri, picomatch, minimatch, serialize-javascript, shell-quote, @babel/plugin-transform- modules-systemjs. Add brace-expansion override for v1 range. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
RHCLOUD-46715 Strip node_modules and system npm packages after build since the runtime only needs nginx to serve static files. This eliminates transitive npm dependency vulnerabilities flagged by grype that originate from the system-installed npm, not the project. Also remove redundant `npm i --only=dev` (npm ci already installs all deps) and unused `npm install yarn` (no build scripts use yarn).
0bbc6a2 to
a2cb7eb
Compare
|
@platex-rehor-bot Can you explain why you're overriding brace-expansion to 1.1.13 specifically? |
RHCLOUD-46715 brace-expansion 1.1.15 is already patched for GHSA-f886-m6hf-6m8v (vulnerable range < 1.1.13). The override was unnecessarily downgrading from 1.1.15 to 1.1.13. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Good catch — the override was targeting GHSA-f886-m6hf-6m8v (brace-expansion zero-step sequence DoS, vulnerable range I've removed the override in c8a42bb — brace-expansion now resolves to 1.1.15 (matching upstream master). |
|
@platex-rehor-bot Is this still a valid PR then? As far as I can tell it currently just removes a comment and updates package-lock with no changes to package. Can you take another look through it and see if it's still valid and worth merging, or if it can just be closed? |
|
You're right — after removing the brace-expansion override in c8a42bb, the only remaining changes are a Dockerfile comment and lockfile churn from dev dependency version bumps (electron-to-chromium, ajv, schema-utils). None of these address the original axios SSRF vulnerability (CVE-2025-62718). The transitive dependency overrides that were originally in |
Description
Update axios lockfile resolution from 1.14.0 to 1.17.0 to remediate CVE-2025-62718 (SSRF and proxy bypass due to improper hostname normalization in axios <1.15.0). The
package.jsonsemver range (^1.8.3) already covered the fix version, so onlypackage-lock.jsonchanges.Additionally resolves pre-existing grype scan failures by:
npm audit fixto update transitive dependencies (braces, minimatch, picomatch, immutable, flatted, fast-uri) to their fixed versions in the lockfile.npm i --only=dev(npm ci already installs all deps) and unusednpm install yarn(no build scripts use yarn) from the Dockerfile.RHCLOUD-46715
Anything reviewers should know?
package.jsonmodification needed since^1.8.3already accepts1.17.0.npm auditconfirms no remaining axios vulnerabilities.Checklist
AI disclosure
Assisted by: Claude Code