chore(deps): update module go.yaml.in/yaml/v2 to v3#429
chore(deps): update module go.yaml.in/yaml/v2 to v3#429red-hat-konflux[bot] wants to merge 1 commit intomainfrom
Conversation
|
ed81ad4 to
e84378b
Compare
e84378b to
46c5050
Compare
46c5050 to
d3f338d
Compare
d3f338d to
5fe1620
Compare
48f6a90 to
5fe1620
Compare
48f6a90 to
6c66e30
Compare
6c66e30 to
b49c126
Compare
b49c126 to
e1ab475
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Summary by CodeRabbit
WalkthroughThe PR updates an indirect Go module requirement in ChangesDependency Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 9/10 reviews remaining, refill in 6 minutes. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 61: The go.mod contains two distinct module paths for the same YAML
library (go.yaml.in/yaml/v3 v3.0.4 and gopkg.in/yaml.v3 v3.0.1) causing
duplicate versions and potential type incompatibilities; resolve by either
updating dependent modules (e.g., bump github.com/oapi-codegen/oapi-codegen/v2
or others that pull gopkg.in/yaml.v3) to versions that depend on
go.yaml.in/yaml/v3, or add an explicit replace directive to unify the paths
(e.g., replace gopkg.in/yaml.v3 => go.yaml.in/yaml/v3) in go.mod so both import
paths resolve to the same module version; ensure you run go mod tidy after the
change and verify tests/builds to confirm no breakage.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| github.com/vmware-labs/yaml-jsonpath v0.3.2 // indirect | ||
| github.com/woodsbury/decimal128 v1.4.0 // indirect | ||
| go.yaml.in/yaml/v2 v2.4.4 // indirect | ||
| go.yaml.in/yaml/v3 v3.0.4 // indirect |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check the dependency graph to identify what pulls in each yaml version
echo "=== Dependencies requiring gopkg.in/yaml.v3 ==="
go mod graph | grep 'gopkg.in/yaml.v3'
echo -e "\n=== Dependencies requiring go.yaml.in/yaml/v3 ==="
go mod graph | grep 'go.yaml.in/yaml/v3'
echo -e "\n=== Why gopkg.in/yaml.v3@v3.0.1 is needed ==="
go mod why gopkg.in/yaml.v3
echo -e "\n=== Why go.yaml.in/yaml/v3@v3.0.4 is needed ==="
go mod why go.yaml.in/yaml/v3
echo -e "\n=== Attempting to tidy and verify ==="
go mod tidy
echo "After tidy, checking for remaining duplicates:"
grep -n "yaml.v3" go.mod || echo "No yaml.v3 found after tidy"Repository: RedHatInsights/quickstarts
Length of output: 5267
Duplicate yaml.v3 dependency versions persisting in go.mod.
Lines 61 and 70 both declare yaml.v3 dependencies at different versions: go.yaml.in/yaml/v3 v3.0.4 and gopkg.in/yaml.v3 v3.0.1. While these import paths refer to the same upstream library, Go treats them as separate module paths. The presence of both versions persists even after go mod tidy, indicating that different dependencies in the tree explicitly require these versions—go.yaml.in/yaml/v3@v3.0.4 is pulled by github.com/onsi/gomega@v1.39.1, while gopkg.in/yaml.v3@v3.0.1 is pulled by github.com/oapi-codegen/oapi-codegen/v2 and others. This can cause subtle type incompatibilities if code from packages using different import paths interacts.
To resolve, consider:
- Updating dependencies that pull
gopkg.in/yaml.v3@v3.0.1to versions that usego.yaml.in/yaml/v3instead, or - Adding an explicit replace directive in go.mod to alias one import path to the other (e.g.,
replace gopkg.in/yaml.v3 => go.yaml.in/yaml/v3), or - Investigating whether all dependencies can be updated to standardize on the canonical
go.yaml.in/yaml/v3import path.
Also applies to: 70-70
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` at line 61, The go.mod contains two distinct module paths for the
same YAML library (go.yaml.in/yaml/v3 v3.0.4 and gopkg.in/yaml.v3 v3.0.1)
causing duplicate versions and potential type incompatibilities; resolve by
either updating dependent modules (e.g., bump
github.com/oapi-codegen/oapi-codegen/v2 or others that pull gopkg.in/yaml.v3) to
versions that depend on go.yaml.in/yaml/v3, or add an explicit replace directive
to unify the paths (e.g., replace gopkg.in/yaml.v3 => go.yaml.in/yaml/v3) in
go.mod so both import paths resolve to the same module version; ensure you run
go mod tidy after the change and verify tests/builds to confirm no breakage.
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
e1ab475 to
80e6e13
Compare
This PR contains the following updates:
v2.4.4→v3.0.4Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
yaml/go-yaml (go.yaml.in/yaml/v2)
v3.0.4Compare Source
v3.0.3Compare Source
v3.0.2Compare Source
v3.0.1Compare Source
v3.0.0Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.