Conversation
Alias x.y to xServer for rhel major versions <=7 when matching repos so rhel repolist is closer to yum. RHINENG-26908
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
==========================================
+ Coverage 70.72% 70.84% +0.12%
==========================================
Files 30 30
Lines 2842 2854 +12
==========================================
+ Hits 2010 2022 +12
Misses 722 722
Partials 110 110
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduced on a RHEL 7.9 VM: yum repolist looked the same for 7.9 and after
subscription-manager release --set=7Server(and checking redhat.repo). Vulnerability report did not. With rhsm_version=7.9 we got different number of CVEs reported. Same host, different releasever only.That’s because vmaas filters repos by releasever. So 7.9 and 7Server hit different repo sets - which is intentional as strict matching and caused by setting
subscription-manager release --set=7.9which is a user preference setup.RHEL 7 has the dual 7.9 and 7Server naming that looks like that yum treats as equivalent. This hotfix does the same in vmaas-lib: alias
{x}.{y} -> {x}Serverbefore matching. We don’t see this on RHEL 8+ since releasevers are numeric and already match what is being stored (RHEL 8+ uses {major}.{minor}.)I was unable to reproduce on RHEL 6 as it was unable to register the machine with entitlement server.
TLDR: Alias {x}.{y} -> {x}Server for x <= 7 before existing releasever matching in vmaas-lib (passReleasever / repos2IDs).