#22 Fixed bug with not able to removing GeoLocation out of Start Location Field#24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of the "My Location" feature in the
TankifyCalculatorcomponent to better respect user intent when they clear or interact with the start location field. The changes ensure that the user's manual input is not unintentionally overridden by background geolocation updates, and that translations and draft state are always up to date.Enhancements to user location and input handling:
suppressAutoStartFromUserLocationRef,draftStartPointRef,startTextRef, andtRefto manage state and prevent auto-restoring "My Location" after the user clears the start field, unless explicitly requested.suppressAutoStartFromUserLocationRef.current = truewhen the user clears the start field, and reset it tofalsewhen the user clicks "My Location". [1] [2]suppressAutoStartFromUserLocationRef,draftStartPointRef, andstartTextRefbefore auto-filling the start location, ensuring user input is not overwritten. Also updated to use the latest translation reference.State and effect management improvements:
useEffecthooks to keep refs (draftStartPointRef,startTextRef,tRef) in sync with their respective state variables.[](empty), ensuring it only runs on mount/unmount, since refs are now used for the latest values.