update Documentation with runtime-env for docker image deployment#26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves documentation and deployment configuration for running the
tankify-frontendapplication with Docker, making it easier for users to get started and for deployments to securely inject runtime secrets.Documentation improvements:
README.mdanddoc/running-docker.mdto clearly outline two options for running the Docker image: using a prebuilt image from GHCR or building the image locally, including recommended environment variables for debugging and authentication. [1] [2]latest, and updated exampledocker-composeanddocker runcommands accordingly. [1] [2]doc/README.mdby renaming the relevant section to "Run Or Deploy With Docker" for clarity.Deployment configuration:
.github/workflows/deploy.yml) to inject environment variables from thetankify-frontend-runtimesecret at runtime, enabling secure and flexible configuration in production.