This repository was archived by the owner on Apr 7, 2022. It is now read-only.
Open
Conversation
|
Looks good to me. @rv-thopkins? |
|
I think this would be good to support, but I'd like to figure out how to let you specify a specific MFA source, especially for people who have two TOTP sources enabled. May merge this and work on that sometime soonish. Apologies for the delay. |
ghost
mentioned this pull request
erickt
reviewed
Sep 16, 2017
|
|
||
| func findTokenFactor(factors []OktaMfaFactor, factorType string) (*OktaMfaFactor, error) { | ||
| var tokenFactor *OktaMfaFactor | ||
| for _, factor := range factors { |
There was a problem hiding this comment.
If you want to let the user pick how they MFA, check out this other project. It steps through all the response and makes a pretty prompt.
There was a problem hiding this comment.
Yes, it'd be nice to present a list of options the first time and let people choose which one they want... or maybe offer an oktad configure step that sets those things up for people.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for Okta Verify's Push based 2FA.
This still hits the same endpoint as the original, just doesn't actually send any code. After you've approved the request on your phone, the endpoint will return success.