Refactoring#8
Open
DivPro wants to merge 5 commits into
Open
Conversation
jmaitrehenry
reviewed
Oct 8, 2019
jmaitrehenry
left a comment
jmaitrehenry
left a comment
There was a problem hiding this comment.
Nice PR, I was looking for a redis proxy for my project and with this PR I think it will work!
| return sentinels, nil | ||
| } | ||
|
|
||
| func createSentinel(addr string) (*redis.SentinelClient, error) { |
There was a problem hiding this comment.
It's impossible to return an error here, maybe remove the last return argument
Comment on lines
+5
to
+7
| "github.com/DivPro/sentinel_tunnel/cmd/config" | ||
| "github.com/DivPro/sentinel_tunnel/cmd/resolver" | ||
| "github.com/DivPro/sentinel_tunnel/cmd/server" |
Comment on lines
+5
to
+6
| "github.com/DivPro/sentinel_tunnel/cmd/config" | ||
| "github.com/DivPro/sentinel_tunnel/cmd/resolver" |
Author
|
@jmaitrehenry Thank you for feedback, changes will coming soon, |
|
@DivPro may I suggest to move the main to the root directory? Else, we could have some fun issues if you use the project outside your GOPATH |
Author
|
@jmaitrehenry wait please for changes, moving main => root approved |
|
@DivPro did you ever finish your changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
features: