Add environment config to disable RDB checksum#122
Open
jeffreylovitz wants to merge 1 commit intomasterfrom
Open
Add environment config to disable RDB checksum#122jeffreylovitz wants to merge 1 commit intomasterfrom
jeffreylovitz wants to merge 1 commit intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 37.59% 37.69% +0.10%
==========================================
Files 17 17
Lines 2088 2093 +5
==========================================
+ Hits 785 789 +4
- Misses 1303 1304 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jeffreylovitz
force-pushed
the
disable-rdb-checksum
branch
from
75287ee to
d8452ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
disableRdbChecksumargument toEnvinitialization. If set to True, a standard Redis server will be instantiated with the additional argument--rdbchecksum no, which disables validation of RDB checksums. I am unsure if this argument is supported in cluster or enterprise environments.This is useful in tests which manually modify RDB files.