Warn if gcc version is lower than 4.8#21
Open
adamatan wants to merge 1 commit intoRedisLabsModules:masterfrom
Open
Warn if gcc version is lower than 4.8#21adamatan wants to merge 1 commit intoRedisLabsModules:masterfrom
adamatan wants to merge 1 commit intoRedisLabsModules:masterfrom
Conversation
Contributor
|
Actually you can remove -Og completely, but thanks for noticing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
-Ogparameter was introduced in in gcc 4.8. When runningmakewith older versions of gcc (as the default one in OSX/XCode), the following error message appears:The following PR shows an error message if the gcc version is older than 4.8. I've chosen not to exit the make process, just in case this logic would fail in some edge case.
See also: